LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@linux-foundation.org, tglx@linutronix.de,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	tony@bakeyournoodle.com
Subject: Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc
Date: Thu, 7 Feb 2008 14:53:56 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802071449240.2896@woody.linux-foundation.org> (raw)
In-Reply-To: <18347.34100.60973.215093@cargo.ozlabs.ibm.com>



On Fri, 8 Feb 2008, Paul Mackerras wrote:
>
> From: Tony Breeds <tony@bakeyournoodle.com>
> 
> Commit ad7f71674ad7c3c4467e48f6ab9e85516dae2720 corrected the clock
> ..

Please, when mentioning hex numbers, also do the one-liner shortlog.

I realize that in gitk (or even just with two terminal windows open and a 
git repository) it's trivial to just follow the link and see what that 
commit was, but even you're just doing a "git log" or more commonly if you 
read the commit log somewhere else (like a mail gateway that posts them 
automatically when I apply things), it's really much more readable if you 
were to say something like:

  Commit ad7f71674ad7c3c4467e48f6ab9e85516dae2720 ("[POWERPC] Use a 
  sensible default for clock_getres() in the VDSO") corrected the clock
  ...

which reads much mroe naturally without having to go wonder what that 
commit was doing. No?

As it is, I'm pretty used to editing those things in (I do it all the 
time), and I will do so for this email too, but I want to keep bringing 
this up so that I hopfully wouldn't have to do it so often. So please 
write your commit messages with the specific git information available, 
but without _requiring_ people to be git users to get the gist of the 
matter, ok?

			Linus

  reply	other threads:[~2008-02-07 22:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-07 22:24 Paul Mackerras
2008-02-07 22:53 ` Linus Torvalds [this message]
2008-02-08 18:06   ` Paul Jackson
2008-02-08 18:20     ` Harvey Harrison
2008-02-08 18:21     ` Olof Johansson
2008-02-08 18:23       ` Olof Johansson
2008-02-08 18:39         ` Paul Jackson
2008-02-08 18:31     ` Simon Holm Thøgersen
2008-02-11 10:36       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802071449240.2896@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=tony@bakeyournoodle.com \
    --subject='Re: [PATCH] Fix compilation of powerpc asm-offsets.c with old gcc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).