* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 0:56 [GIT PATCH] final SCSI updates for 2.6.24 merge window James Bottomley
@ 2008-02-08 1:04 ` Harvey Harrison
2008-02-08 1:07 ` James Bottomley
2008-02-08 1:37 ` James Bottomley
2008-02-08 2:46 ` Andrew Morton
2 siblings, 1 reply; 15+ messages in thread
From: Harvey Harrison @ 2008-02-08 1:04 UTC (permalink / raw)
To: James Bottomley; +Cc: Andrew Morton, Linus Torvalds, linux-scsi, linux-kernel
On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> Quite a bit of this is fixing things broken previously (the advansys fix
> is still pending resolution, but I'll send it as an -rc fix when we have
> it). There's the final elimination of all drivers that are esp based
> but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> the usual bunch of driver updates and the addition of a new enclosure
> services driver and the corresponding ULD.
>
> The patch is available from:
>
I'm going to guess that this is the entry in feature-removal.txt
that need an update then:
---------------------------
What: old NCR53C9x driver
When: October 2007
Why: Replaced by the much better esp_scsi driver. Actual low-level
driver can be ported over almost trivially.
Who: David Miller <davem@davemloft.net>
Christoph Hellwig <hch@lst.de>
Cheers,
Harvey
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 1:04 ` Harvey Harrison
@ 2008-02-08 1:07 ` James Bottomley
2008-02-08 1:14 ` Harvey Harrison
2008-02-08 9:03 ` Geert Uytterhoeven
0 siblings, 2 replies; 15+ messages in thread
From: James Bottomley @ 2008-02-08 1:07 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Andrew Morton, Linus Torvalds, linux-scsi, linux-kernel
On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> > Quite a bit of this is fixing things broken previously (the advansys fix
> > is still pending resolution, but I'll send it as an -rc fix when we have
> > it). There's the final elimination of all drivers that are esp based
> > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > the usual bunch of driver updates and the addition of a new enclosure
> > services driver and the corresponding ULD.
> >
> > The patch is available from:
> >
>
> I'm going to guess that this is the entry in feature-removal.txt
> that need an update then:
>
> ---------------------------
>
> What: old NCR53C9x driver
> When: October 2007
> Why: Replaced by the much better esp_scsi driver. Actual low-level
> driver can be ported over almost trivially.
> Who: David Miller <davem@davemloft.net>
> Christoph Hellwig <hch@lst.de>
Not immediately ... I anticipate a few "where'd my driver go?" type
questions from m68k for which this provides a useful reference to point
to ...
James
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 1:07 ` James Bottomley
@ 2008-02-08 1:14 ` Harvey Harrison
2008-02-08 9:03 ` Geert Uytterhoeven
1 sibling, 0 replies; 15+ messages in thread
From: Harvey Harrison @ 2008-02-08 1:14 UTC (permalink / raw)
To: James Bottomley; +Cc: Andrew Morton, Linus Torvalds, linux-scsi, linux-kernel
On Thu, 2008-02-07 at 19:07 -0600, James Bottomley wrote:
> On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> > On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> > > Quite a bit of this is fixing things broken previously (the advansys fix
> > > is still pending resolution, but I'll send it as an -rc fix when we have
> > > it). There's the final elimination of all drivers that are esp based
> > > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > > the usual bunch of driver updates and the addition of a new enclosure
> > > services driver and the corresponding ULD.
> > >
> > > The patch is available from:
> > >
> >
> > I'm going to guess that this is the entry in feature-removal.txt
> > that need an update then:
> >
> > ---------------------------
> >
> > What: old NCR53C9x driver
> > When: October 2007
> > Why: Replaced by the much better esp_scsi driver. Actual low-level
> > driver can be ported over almost trivially.
> > Who: David Miller <davem@davemloft.net>
> > Christoph Hellwig <hch@lst.de>
>
> Not immediately ... I anticipate a few "where'd my driver go?" type
> questions from m68k for which this provides a useful reference to point
> to ...
>
> James
>
>
Well, if not removed, how about updated:
What: old NCR53C9x driver
When: Removed Feb 2008
Why: Replaced by the much better esp_scsi driver. Actual low-level
driver can be ported over almost trivially.
Who: James Bottomley <James.Bottomley@HansenPartnership.com>
Cheers,
Harvey
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 1:07 ` James Bottomley
2008-02-08 1:14 ` Harvey Harrison
@ 2008-02-08 9:03 ` Geert Uytterhoeven
2008-02-08 16:37 ` James Bottomley
1 sibling, 1 reply; 15+ messages in thread
From: Geert Uytterhoeven @ 2008-02-08 9:03 UTC (permalink / raw)
To: James Bottomley
Cc: Harvey Harrison, Andrew Morton, Linus Torvalds, linux-scsi,
linux-kernel, Linux/m68k
On Thu, 7 Feb 2008, James Bottomley wrote:
> On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> > On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> > > Quite a bit of this is fixing things broken previously (the advansys fix
> > > is still pending resolution, but I'll send it as an -rc fix when we have
> > > it). There's the final elimination of all drivers that are esp based
> > > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > > the usual bunch of driver updates and the addition of a new enclosure
> > > services driver and the corresponding ULD.
> > >
> > > The patch is available from:
> > >
> >
> > I'm going to guess that this is the entry in feature-removal.txt
> > that need an update then:
> >
> > ---------------------------
> >
> > What: old NCR53C9x driver
> > When: October 2007
> > Why: Replaced by the much better esp_scsi driver. Actual low-level
> > driver can be ported over almost trivially.
> > Who: David Miller <davem@davemloft.net>
> > Christoph Hellwig <hch@lst.de>
>
> Not immediately ... I anticipate a few "where'd my driver go?" type
> questions from m68k for which this provides a useful reference to point
> to ...
Don't bother, we're fully aware of this.
The shortest feature removal notice in Linux's history (is it?) didn't go
unnoticed ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 9:03 ` Geert Uytterhoeven
@ 2008-02-08 16:37 ` James Bottomley
2008-02-11 21:13 ` Harvey Harrison
0 siblings, 1 reply; 15+ messages in thread
From: James Bottomley @ 2008-02-08 16:37 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Harvey Harrison, Andrew Morton, Linus Torvalds, linux-scsi,
linux-kernel, Linux/m68k
On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote:
> On Thu, 7 Feb 2008, James Bottomley wrote:
> > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> > > On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> > > > Quite a bit of this is fixing things broken previously (the advansys fix
> > > > is still pending resolution, but I'll send it as an -rc fix when we have
> > > > it). There's the final elimination of all drivers that are esp based
> > > > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > > > the usual bunch of driver updates and the addition of a new enclosure
> > > > services driver and the corresponding ULD.
> > > >
> > > > The patch is available from:
> > > >
> > >
> > > I'm going to guess that this is the entry in feature-removal.txt
> > > that need an update then:
> > >
> > > ---------------------------
> > >
> > > What: old NCR53C9x driver
> > > When: October 2007
> > > Why: Replaced by the much better esp_scsi driver. Actual low-level
> > > driver can be ported over almost trivially.
> > > Who: David Miller <davem@davemloft.net>
> > > Christoph Hellwig <hch@lst.de>
> >
> > Not immediately ... I anticipate a few "where'd my driver go?" type
> > questions from m68k for which this provides a useful reference to point
> > to ...
>
> Don't bother, we're fully aware of this.
>
> The shortest feature removal notice in Linux's history (is it?) didn't go
> unnoticed ;-)
I don't know where you get that from. The notice went in on 30 April
2007 and we gave you six months to convert the drivers, hence the
October 2007 date for when the deletion will actually be done. I've
actually delayed removal until February 2007 giving you a further three
months. Even then I only removed the drivers because they no longer
compile.
I think nine months isn't unreasonable for a feature removal ... unless
you work on a different time scale from me?
James
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 16:37 ` James Bottomley
@ 2008-02-11 21:13 ` Harvey Harrison
2008-02-11 22:02 ` James Bottomley
0 siblings, 1 reply; 15+ messages in thread
From: Harvey Harrison @ 2008-02-11 21:13 UTC (permalink / raw)
To: James Bottomley
Cc: Geert Uytterhoeven, Andrew Morton, Linus Torvalds, linux-scsi,
linux-kernel, Linux/m68k
On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote:
> On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote:
> > On Thu, 7 Feb 2008, James Bottomley wrote:
> > > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> > > > I'm going to guess that this is the entry in feature-removal.txt
> > > > that need an update then:
> > > >
> > > > ---------------------------
> > > >
> > > > What: old NCR53C9x driver
> > > > When: October 2007
> > > > Why: Replaced by the much better esp_scsi driver. Actual low-level
> > > > driver can be ported over almost trivially.
> > > > Who: David Miller <davem@davemloft.net>
> > > > Christoph Hellwig <hch@lst.de>
> > >
> > > Not immediately ... I anticipate a few "where'd my driver go?" type
> > > questions from m68k for which this provides a useful reference to point
> > > to ...
> >
> > Don't bother, we're fully aware of this.
> >
> > The shortest feature removal notice in Linux's history (is it?) didn't go
> > unnoticed ;-)
So....would a patch be welcome to remove this entry then?
Harvey
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-11 21:13 ` Harvey Harrison
@ 2008-02-11 22:02 ` James Bottomley
0 siblings, 0 replies; 15+ messages in thread
From: James Bottomley @ 2008-02-11 22:02 UTC (permalink / raw)
To: Harvey Harrison
Cc: Geert Uytterhoeven, Andrew Morton, Linus Torvalds, linux-scsi,
linux-kernel, Linux/m68k
On Mon, 2008-02-11 at 13:13 -0800, Harvey Harrison wrote:
> On Fri, 2008-02-08 at 10:37 -0600, James Bottomley wrote:
> > On Fri, 2008-02-08 at 10:03 +0100, Geert Uytterhoeven wrote:
> > > On Thu, 7 Feb 2008, James Bottomley wrote:
> > > > On Thu, 2008-02-07 at 17:04 -0800, Harvey Harrison wrote:
> > > > > I'm going to guess that this is the entry in feature-removal.txt
> > > > > that need an update then:
> > > > >
> > > > > ---------------------------
> > > > >
> > > > > What: old NCR53C9x driver
> > > > > When: October 2007
> > > > > Why: Replaced by the much better esp_scsi driver. Actual low-level
> > > > > driver can be ported over almost trivially.
> > > > > Who: David Miller <davem@davemloft.net>
> > > > > Christoph Hellwig <hch@lst.de>
> > > >
> > > > Not immediately ... I anticipate a few "where'd my driver go?" type
> > > > questions from m68k for which this provides a useful reference to point
> > > > to ...
> > >
> > > Don't bother, we're fully aware of this.
> > >
> > > The shortest feature removal notice in Linux's history (is it?) didn't go
> > > unnoticed ;-)
>
> So....would a patch be welcome to remove this entry then?
Not at the moment for the reasons I already gave. Ping me in about
three months if it's not gone by then.
James
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 0:56 [GIT PATCH] final SCSI updates for 2.6.24 merge window James Bottomley
2008-02-08 1:04 ` Harvey Harrison
@ 2008-02-08 1:37 ` James Bottomley
2008-02-08 3:53 ` FUJITA Tomonori
2008-02-08 2:46 ` Andrew Morton
2 siblings, 1 reply; 15+ messages in thread
From: James Bottomley @ 2008-02-08 1:37 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linus Torvalds, linux-scsi, linux-kernel
On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> Quite a bit of this is fixing things broken previously (the advansys fix
> is still pending resolution, but I'll send it as an -rc fix when we have
> it). There's the final elimination of all drivers that are esp based
> but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> the usual bunch of driver updates and the addition of a new enclosure
> services driver and the corresponding ULD.
OK, the advansys fix came in. I've added it to the patch.
James
----
>From f983323fea178352ed3b69c70561a13825a3ce59 Mon Sep 17 00:00:00 2001
From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Date: Fri, 8 Feb 2008 09:50:08 +0900
Subject: [SCSI] advansys: fix overrun_buf aligned bug
struct asc_dvc_var needs overrun buffer to be placed on an 8 byte
boundary. advansys defines struct asc_dvc_var:
struct asc_dvc_var {
...
uchar overrun_buf[ASC_OVERRUN_BSIZE] __aligned(8);
The problem is that struct asc_dvc_var is placed on
shost->hostdata. So if the hostdata is not on an 8 byte boundary, the
advansys crashes. The hostdata is placed on a sizeof(unsigned long)
boundary so the 8 byte boundary is not garanteed with x86_32.
With 2.6.23 and 2.6.24, the hostdata is on an 8 byte boundary by
chance, but with the current git, it's not.
This patch removes overrun_buf static array and use kzalloc.
Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
---
drivers/scsi/advansys.c | 13 +++++++++++--
1 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index ccef891..3c2d688 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -566,7 +566,7 @@ typedef struct asc_dvc_var {
ASC_SCSI_BIT_ID_TYPE unit_not_ready;
ASC_SCSI_BIT_ID_TYPE queue_full_or_busy;
ASC_SCSI_BIT_ID_TYPE start_motor;
- uchar overrun_buf[ASC_OVERRUN_BSIZE] __aligned(8);
+ uchar *overrun_buf;
dma_addr_t overrun_dma;
uchar scsi_reset_wait;
uchar chip_no;
@@ -13833,6 +13833,12 @@ static int __devinit advansys_board_found(struct Scsi_Host *shost,
*/
if (ASC_NARROW_BOARD(boardp)) {
ASC_DBG(2, "AscInitAsc1000Driver()\n");
+
+ asc_dvc_varp->overrun_buf = kzalloc(ASC_OVERRUN_BSIZE, GFP_KERNEL);
+ if (!asc_dvc_varp->overrun_buf) {
+ ret = -ENOMEM;
+ goto err_free_wide_mem;
+ }
warn_code = AscInitAsc1000Driver(asc_dvc_varp);
if (warn_code || asc_dvc_varp->err_code) {
@@ -13840,8 +13846,10 @@ static int __devinit advansys_board_found(struct Scsi_Host *shost,
"warn 0x%x, error 0x%x\n",
asc_dvc_varp->init_state, warn_code,
asc_dvc_varp->err_code);
- if (asc_dvc_varp->err_code)
+ if (asc_dvc_varp->err_code) {
ret = -ENODEV;
+ kfree(asc_dvc_varp->overrun_buf);
+ }
}
} else {
if (advansys_wide_init_chip(shost))
@@ -13894,6 +13902,7 @@ static int advansys_release(struct Scsi_Host *shost)
dma_unmap_single(board->dev,
board->dvc_var.asc_dvc_var.overrun_dma,
ASC_OVERRUN_BSIZE, DMA_FROM_DEVICE);
+ kfree(board->dvc_var.asc_dvc_var.overrun_buf);
} else {
iounmap(board->ioremap_addr);
advansys_wide_free_mem(board);
--
1.5.3.8
^ permalink raw reply related [flat|nested] 15+ messages in thread* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 1:37 ` James Bottomley
@ 2008-02-08 3:53 ` FUJITA Tomonori
0 siblings, 0 replies; 15+ messages in thread
From: FUJITA Tomonori @ 2008-02-08 3:53 UTC (permalink / raw)
To: James.Bottomley; +Cc: akpm, torvalds, linux-scsi, linux-kernel
On Thu, 07 Feb 2008 19:37:07 -0600
James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> On Thu, 2008-02-07 at 18:56 -0600, James Bottomley wrote:
> > Quite a bit of this is fixing things broken previously (the advansys fix
> > is still pending resolution, but I'll send it as an -rc fix when we have
> > it). There's the final elimination of all drivers that are esp based
> > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > the usual bunch of driver updates and the addition of a new enclosure
> > services driver and the corresponding ULD.
>
> OK, the advansys fix came in. I've added it to the patch.
>
> James
>
> ----
>
> >From f983323fea178352ed3b69c70561a13825a3ce59 Mon Sep 17 00:00:00 2001
> From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Date: Fri, 8 Feb 2008 09:50:08 +0900
> Subject: [SCSI] advansys: fix overrun_buf aligned bug
Seems that it was a bit late, Linus pulled scsi-misc before the patch
was added.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 0:56 [GIT PATCH] final SCSI updates for 2.6.24 merge window James Bottomley
2008-02-08 1:04 ` Harvey Harrison
2008-02-08 1:37 ` James Bottomley
@ 2008-02-08 2:46 ` Andrew Morton
2008-02-08 3:11 ` Linus Torvalds
2008-02-08 3:16 ` James Bottomley
2 siblings, 2 replies; 15+ messages in thread
From: Andrew Morton @ 2008-02-08 2:46 UTC (permalink / raw)
To: James Bottomley; +Cc: Linus Torvalds, linux-scsi, linux-kernel, Nick Piggin
On Thu, 07 Feb 2008 18:56:46 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> Quite a bit of this is fixing things broken previously (the advansys fix
> is still pending resolution, but I'll send it as an -rc fix when we have
> it). There's the final elimination of all drivers that are esp based
> but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> the usual bunch of driver updates and the addition of a new enclosure
> services driver and the corresponding ULD.
Sob. Can we please merge "Convert SG from nopage to fault"? It has been
sent three times, the first time was Dec 5 last year and it has thus far
received the lead balloon treatment. Despite my explicit request for
consideration last time I sent it
If there is no movement here then I have to carry the moderately intrusive
mm-remove-nopage.patch for another N months and we need to watch out for
new ->nopage implementations popping up etc.
From: Nick Piggin <npiggin@suse.de>
Convert SG from nopage to fault.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Cc: Douglas Gilbert <dougg@torque.net>
Cc: James Bottomley <James.Bottomley@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/scsi/sg.c | 23 +++++++++++------------
1 file changed, 11 insertions(+), 12 deletions(-)
diff -puN drivers/scsi/sg.c~sg-nopage drivers/scsi/sg.c
--- a/drivers/scsi/sg.c~sg-nopage
+++ a/drivers/scsi/sg.c
@@ -1160,23 +1160,22 @@ sg_fasync(int fd, struct file *filp, int
return (retval < 0) ? retval : 0;
}
-static struct page *
-sg_vma_nopage(struct vm_area_struct *vma, unsigned long addr, int *type)
+static int
+sg_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
{
Sg_fd *sfp;
- struct page *page = NOPAGE_SIGBUS;
unsigned long offset, len, sa;
Sg_scatter_hold *rsv_schp;
struct scatterlist *sg;
int k;
if ((NULL == vma) || (!(sfp = (Sg_fd *) vma->vm_private_data)))
- return page;
+ return VM_FAULT_SIGBUS;
rsv_schp = &sfp->reserve;
- offset = addr - vma->vm_start;
+ offset = vmf->pgoff << PAGE_SHIFT;
if (offset >= rsv_schp->bufflen)
- return page;
- SCSI_LOG_TIMEOUT(3, printk("sg_vma_nopage: offset=%lu, scatg=%d\n",
+ return VM_FAULT_SIGBUS;
+ SCSI_LOG_TIMEOUT(3, printk("sg_vma_fault: offset=%lu, scatg=%d\n",
offset, rsv_schp->k_use_sg));
sg = rsv_schp->buffer;
sa = vma->vm_start;
@@ -1185,21 +1184,21 @@ sg_vma_nopage(struct vm_area_struct *vma
len = vma->vm_end - sa;
len = (len < sg->length) ? len : sg->length;
if (offset < len) {
+ struct page *page;
page = virt_to_page(page_address(sg_page(sg)) + offset);
get_page(page); /* increment page count */
- break;
+ vmf->page = page;
+ return 0; /* success */
}
sa += len;
offset -= len;
}
- if (type)
- *type = VM_FAULT_MINOR;
- return page;
+ return VM_FAULT_SIGBUS;
}
static struct vm_operations_struct sg_mmap_vm_ops = {
- .nopage = sg_vma_nopage,
+ .fault = sg_vma_fault,
};
static int
_
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 2:46 ` Andrew Morton
@ 2008-02-08 3:11 ` Linus Torvalds
2008-02-08 5:05 ` Christoph Hellwig
2008-02-08 3:16 ` James Bottomley
1 sibling, 1 reply; 15+ messages in thread
From: Linus Torvalds @ 2008-02-08 3:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: James Bottomley, linux-scsi, linux-kernel, Nick Piggin
On Thu, 7 Feb 2008, Andrew Morton wrote:
>
> Sob. Can we please merge "Convert SG from nopage to fault"?
Heh. I just took it directly then.
I think it's more of a VM patch than a SCSI patch anyway, so I don't think
you really should even have tried to push it through the SCSI tree.
It's not like we ever do the low-level FS changes for VFS issues through
the FS maintainers anyway (ie you sent me all those iget/read_inode things
directly rather than trying to go through each filesystem). I don't think
this is any different, really.
Linus
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 3:11 ` Linus Torvalds
@ 2008-02-08 5:05 ` Christoph Hellwig
0 siblings, 0 replies; 15+ messages in thread
From: Christoph Hellwig @ 2008-02-08 5:05 UTC (permalink / raw)
To: Linus Torvalds
Cc: Andrew Morton, James Bottomley, linux-scsi, linux-kernel, Nick Piggin
On Thu, Feb 07, 2008 at 07:11:33PM -0800, Linus Torvalds wrote:
>
>
> On Thu, 7 Feb 2008, Andrew Morton wrote:
> >
> > Sob. Can we please merge "Convert SG from nopage to fault"?
>
> Heh. I just took it directly then.
>
> I think it's more of a VM patch than a SCSI patch anyway, so I don't think
> you really should even have tried to push it through the SCSI tree.
>
> It's not like we ever do the low-level FS changes for VFS issues through
> the FS maintainers anyway (ie you sent me all those iget/read_inode things
> directly rather than trying to go through each filesystem). I don't think
> this is any different, really.
Yes. For ->faul Nick should just have sent on the whole batch after
giving fs/driver people enough time to review it.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 2:46 ` Andrew Morton
2008-02-08 3:11 ` Linus Torvalds
@ 2008-02-08 3:16 ` James Bottomley
2008-02-08 3:24 ` Andrew Morton
1 sibling, 1 reply; 15+ messages in thread
From: James Bottomley @ 2008-02-08 3:16 UTC (permalink / raw)
To: Andrew Morton
Cc: Linus Torvalds, linux-scsi, linux-kernel, Nick Piggin, dougg
On Thu, 2008-02-07 at 18:46 -0800, Andrew Morton wrote:
> On Thu, 07 Feb 2008 18:56:46 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> > Quite a bit of this is fixing things broken previously (the advansys fix
> > is still pending resolution, but I'll send it as an -rc fix when we have
> > it). There's the final elimination of all drivers that are esp based
> > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > the usual bunch of driver updates and the addition of a new enclosure
> > services driver and the corresponding ULD.
>
> Sob. Can we please merge "Convert SG from nopage to fault"? It has been
> sent three times, the first time was Dec 5 last year and it has thus far
> received the lead balloon treatment. Despite my explicit request for
> consideration last time I sent it
>
> If there is no movement here then I have to carry the moderately intrusive
> mm-remove-nopage.patch for another N months and we need to watch out for
> new ->nopage implementations popping up etc.
I agree ... I've pinged Doug privately, this is publicly.
Unfortunately, it is an intrusive change and needs testing .. I just
don't have the tools that do this for SG.
James
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [GIT PATCH] final SCSI updates for 2.6.24 merge window
2008-02-08 3:16 ` James Bottomley
@ 2008-02-08 3:24 ` Andrew Morton
0 siblings, 0 replies; 15+ messages in thread
From: Andrew Morton @ 2008-02-08 3:24 UTC (permalink / raw)
To: James Bottomley
Cc: Linus Torvalds, linux-scsi, linux-kernel, Nick Piggin, dougg
On Thu, 07 Feb 2008 21:16:43 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Thu, 2008-02-07 at 18:46 -0800, Andrew Morton wrote:
> > On Thu, 07 Feb 2008 18:56:46 -0600 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> >
> > > Quite a bit of this is fixing things broken previously (the advansys fix
> > > is still pending resolution, but I'll send it as an -rc fix when we have
> > > it). There's the final elimination of all drivers that are esp based
> > > but don't use the scsi_esp core (that's mostly m68k and alpha). Plus
> > > the usual bunch of driver updates and the addition of a new enclosure
> > > services driver and the corresponding ULD.
> >
> > Sob. Can we please merge "Convert SG from nopage to fault"? It has been
> > sent three times, the first time was Dec 5 last year and it has thus far
> > received the lead balloon treatment. Despite my explicit request for
> > consideration last time I sent it
> >
> > If there is no movement here then I have to carry the moderately intrusive
> > mm-remove-nopage.patch for another N months and we need to watch out for
> > new ->nopage implementations popping up etc.
>
> I agree ... I've pinged Doug privately, this is publicly.
> Unfortunately, it is an intrusive change and needs testing .. I just
> don't have the tools that do this for SG.
>
I keep on forgetting that sg==dougg.
<looks in MAINTAINERS. Shifts blame.>
In fact scsi is the area in which I have the most who-maintains-what
trouble. I just don't believe what MAINTAINERS says about scsi drivers and
I tend to resort to git-whatchanged to find out who's really doing stuff.
The number of people@lsil.com makes my head spin and I tend to cc as many
as I can get my hands on.
IOW: some care and attention to the ./MAINTAINERS file would really help
here.
^ permalink raw reply [flat|nested] 15+ messages in thread