LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [3/3] Enable ACPI extended century handling for 32bit too
Date: Sat, 9 Feb 2008 11:39:11 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802091136380.3145@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080208121455.228C31B41BB@basil.firstfloor.org>

On Fri, 8 Feb 2008, Andi Kleen wrote:

> 
> Not that it matters much, see comment in the code.
> 
> Signed-off-by: Andi Kleen <ak@suse.de>
> 
> ---
>  arch/x86/kernel/rtc.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> Index: linux/arch/x86/kernel/rtc.c
> ===================================================================
> --- linux.orig/arch/x86/kernel/rtc.c
> +++ linux/arch/x86/kernel/rtc.c
> @@ -112,12 +112,13 @@ unsigned long mach_get_cmos_time(void)
>  	mon = CMOS_READ(RTC_MONTH);
>  	year = CMOS_READ(RTC_YEAR);
>  
> -#if defined(CONFIG_ACPI) && defined(CONFIG_X86_64)
> -	/* CHECKME: Is this really 64bit only ??? */
> +	/*
> +	 * On 32bit not strictly needed because the world ends in 2038
> +	 * and the code can handle that with the 2 digit heuristics.
> +	 */
>  	if (acpi_gbl_FADT.header.revision >= FADT2_REVISION_ID &&
>  	    acpi_gbl_FADT.century)
>  		century = CMOS_READ(acpi_gbl_FADT.century);

How does this compile with CONFIG_ACPI=n ?

Thanks,
	tglx

  reply	other threads:[~2008-02-09 10:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-08 12:14 [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD Andi Kleen
2008-02-08 12:14 ` [PATCH] [2/3] Use 2000 offset for 32bit kernels Andi Kleen
2008-02-08 12:14 ` [PATCH] [3/3] Enable ACPI extended century handling for 32bit too Andi Kleen
2008-02-09 10:39   ` Thomas Gleixner [this message]
2008-02-09 10:28 ` [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD Thomas Gleixner
2008-02-09 14:55   ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802091136380.3145@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH] [3/3] Enable ACPI extended century handling for 32bit too' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).