LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)
@ 2008-02-10  2:57 S.Çağlar Onur
  2008-02-10  9:52 ` Richard Knutsson
  0 siblings, 1 reply; 6+ messages in thread
From: S.Çağlar Onur @ 2008-02-10  2:57 UTC (permalink / raw)
  To: linux-kernel; +Cc: davem, torvalds, hidave.darkstar, marcel

Hi;

Following patch silents

net/bluetooth/hci_sysfs.c: In function `del_conn':
net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value

compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

Signed-off-by: S.Çağlar Onur <caglar@pardus.org.tr>

 net/bluetooth/hci_sysfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_sysfs.c b/net/bluetooth/hci_sysfs.c
index e13cf5e..d2d1e4f 100644
--- a/net/bluetooth/hci_sysfs.c
+++ b/net/bluetooth/hci_sysfs.c
@@ -336,7 +336,7 @@ static void del_conn(struct work_struct *work)
 	struct device *dev;
 	struct hci_conn *conn = container_of(work, struct hci_conn, work);
 
-	while (dev = device_find_child(&conn->dev, NULL, __match_tty)) {
+	while ((dev = device_find_child(&conn->dev, NULL, __match_tty)) != NULL) {
 		device_move(dev, NULL);
 		put_device(dev);
 	}

Cheers
-- 
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2008-02-11 12:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-10  2:57 [PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.) S.Çağlar Onur
2008-02-10  9:52 ` Richard Knutsson
2008-02-10 14:21   ` S.Çağlar Onur
2008-02-10 18:58     ` Linus Torvalds
2008-02-10 22:05       ` S.Çağlar Onur
2008-02-11 12:53         ` Stefan Richter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).