LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <ak@suse.de>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD
Date: Mon, 11 Feb 2008 23:08:57 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802112246590.12988@apollo.tec.linutronix.de> (raw)
In-Reply-To: <200802110956.16004.ak@suse.de>

On Mon, 11 Feb 2008, Andi Kleen wrote:
> > Nothing ever defines RTC_PORT and RTC_ALWAYS_BCD
> >
> > So we can get rid of that stuff completely.
> 
> Please see the second version of the patch series. This means I didn't drop it 

I'm already replying to the second version of the patch series AFAICT.

> completely, but added a warning about it not agreeing with the status 
> register. If this warning never triggers it can be dropped eventually,
> if it triggers RTC_ALWAYS_BCD should be unset.

#define RTC_ALWAYS_BCD 1 is there since Linux 1.0 and got never
changed for x86.

So the warning comes a bit late :)

Later on the #ifdef RTC_PORT was introduced to share the header in
include/linux across architectures. When the header got copied to
include/i386 and elsewhere this just was never removed.

Thanks,

	tglx

  reply	other threads:[~2008-02-11 22:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-09 15:16 Andi Kleen
2008-02-09 15:16 ` [PATCH] [2/5] Use 2000 offset for 32bit kernels Andi Kleen
2008-02-16 19:24   ` Thomas Gleixner
2008-02-20 10:07     ` Thomas Gleixner
2008-02-20 10:23       ` Andi Kleen
2008-02-09 15:16 ` [PATCH] [3/5] Add warning when RTC clock reports binary Andi Kleen
2008-02-16 19:38   ` Thomas Gleixner
2008-02-09 15:17 ` [PATCH] [4/5] Fix wrong comment Andi Kleen
2008-02-09 15:17 ` [PATCH] [5/5] Enable ACPI extended century handling for 32bit too v2 Andi Kleen
2008-02-16 19:38   ` Thomas Gleixner
2008-02-11  8:30 ` [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD Thomas Gleixner
2008-02-11  8:56   ` Andi Kleen
2008-02-11 22:08     ` Thomas Gleixner [this message]
2008-02-11 22:15       ` Andi Kleen
2008-02-12 20:36         ` Thomas Gleixner
2008-02-13 13:49           ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802112246590.12988@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH] [1/5] Only do century BCD conversion when we know the RTC is BCD' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).