LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nicolas Pitre <nico@cam.org>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS
Date: Thu, 14 Feb 2008 09:03:09 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802140902460.2732@xanadu.home> (raw)
In-Reply-To: <1202952946-10511-1-git-send-email-khilman@mvista.com>

On Wed, 13 Feb 2008, Kevin Hilman wrote:

> The smc_special_locks should also be used when either softIRQs or hard
> IRQs are preempted which may lead to the same problems as under SMP.
> 
> Signed-off-by: Kevin Hilman <khilman@mvista.com>

Acked-by: Nicolas Pitre <nico@cam.org>

> 
> ---
>  drivers/net/smc91x.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/smc91x.c b/drivers/net/smc91x.c
> index f198c49..be62616 100644
> --- a/drivers/net/smc91x.c
> +++ b/drivers/net/smc91x.c
> @@ -530,7 +530,8 @@ static inline void  smc_rcv(struct net_device *dev)
>  	}
>  }
>  
> -#ifdef CONFIG_SMP
> +#if defined(CONFIG_SMP) ||						\
> +    defined(CONFIG_PREEMPT_SOFTIRQS) || defined(CONFIG_PREEMPT_HARDIRQS)
>  /*
>   * On SMP we have the following problem:
>   *
> -- 
> 1.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 


Nicolas

      reply	other threads:[~2008-02-14 14:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-14  1:35 Kevin Hilman
2008-02-14 14:03 ` Nicolas Pitre [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802140902460.2732@xanadu.home \
    --to=nico@cam.org \
    --cc=khilman@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --subject='Re: [PATCH 2.6.24-rt1] SMC91x: Use special_lock when CONFIG_PREEMPT_[HARD|SOFT]IRQS' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).