LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [build bug] lguest build failure: drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference to `LGUEST_PAGES_regs_trapnum'
Date: Sun, 17 Feb 2008 14:51:27 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802171451060.7583@apollo.tec.linutronix.de> (raw)
In-Reply-To: <200802040711.11280.rusty@rustcorp.com.au>

On Mon, 4 Feb 2008, Rusty Russell wrote:

> On Saturday 02 February 2008 04:05:51 Ingo Molnar wrote:
> > looks similar to the previous one so i guess my quick fix attempt was a
> > bit too quick. Will turn lguest off again. And i'm willing to test
> > patches as well :)
> 
> Hi Ingo,
> 
>    OK, this problem was caused by asm-offsets.c only having the offsets when
> lguest *guest* support was set, not lguest host (host support used to imply
> guest support, so now they're separate these bugs come out).
> 
> Can you throw this patch into your tree for testing?
> 
> Thanks,
> Rusty.

Applied. Thanks,

	 tglx
 
> Lguest guest support and host support are separate config options: they used
> to be tied together.  Sort out which parts of asm-offsets are needed for Guest
> and Host.
> 
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> 
> diff -r 7d5a5c7a4b95 arch/x86/kernel/asm-offsets_32.c
> --- a/arch/x86/kernel/asm-offsets_32.c	Sat Feb 02 23:13:05 2008 +1100
> +++ b/arch/x86/kernel/asm-offsets_32.c	Sun Feb 03 10:13:19 2008 +1100
> @@ -20,10 +20,8 @@
>  
>  #include <xen/interface/xen.h>
>  
> -#ifdef CONFIG_LGUEST_GUEST
>  #include <linux/lguest.h>
>  #include "../../../drivers/lguest/lg.h"
> -#endif
>  
>  #define DEFINE(sym, val) \
>          asm volatile("\n->" #sym " %0 " #val : : "i" (val))
> @@ -134,6 +132,10 @@ void foo(void)
>  	BLANK();
>  	OFFSET(LGUEST_DATA_irq_enabled, lguest_data, irq_enabled);
>  	OFFSET(LGUEST_DATA_pgdir, lguest_data, pgdir);
> +#endif
> +
> +#ifdef CONFIG_LGUEST
> +	BLANK();
>  	OFFSET(LGUEST_PAGES_host_gdt_desc, lguest_pages, state.host_gdt_desc);
>  	OFFSET(LGUEST_PAGES_host_idt_desc, lguest_pages, state.host_idt_desc);
>  	OFFSET(LGUEST_PAGES_host_cr3, lguest_pages, state.host_cr3);
> 

  reply	other threads:[~2008-02-17 13:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-01 12:45 Ingo Molnar
2008-02-01 17:05 ` Ingo Molnar
2008-02-02 12:25   ` Rusty Russell
2008-02-03 20:11   ` Rusty Russell
2008-02-17 13:51     ` Thomas Gleixner [this message]
2008-02-17 14:07       ` Sergio Luis
2008-02-17 20:11         ` Christian Kujau
2008-02-18  1:04           ` Sergio Luis
2008-02-18  1:31             ` Sergio Luis
2008-02-18 22:14               ` Christian Kujau
2008-02-18 22:19                 ` Sergio Luis
2008-02-19 21:20                   ` Christian Kujau
2008-02-19  3:44     ` [PATCH] Fix building lguest as module Tony Breeds
2008-02-19  7:32       ` Ingo Molnar
2008-02-19 13:54         ` Ingo Molnar
2008-02-19 23:35           ` Tony Breeds
2008-02-20  9:33             ` Ingo Molnar
2008-02-20 10:01             ` Ingo Molnar
2008-02-22  5:58               ` Tony Breeds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802171451060.7583@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    --subject='Re: [build bug] lguest build failure: drivers/lguest/x86/switcher_32.S:(.text+0x3815f8): undefined reference to `LGUEST_PAGES_regs_trapnum'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).