LKML Archive on
help / color / mirror / Atom feed
From: Thomas Gleixner <>
To: Yinghai Lu <Yinghai.Lu@Sun.COM>
Cc: Ingo Molnar <>,
	Andrew Morton <>,
	Greg KH <>,
	Linux Kernel Mailing List <>
Subject: Re: [PATCH 1/5] x86: validate against acpi motherboard resources
Date: Sun, 17 Feb 2008 15:06:16 +0100 (CET)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 15 Feb 2008, Yinghai Lu wrote:
> From: Robert Hancock <>
> This path adds validation of the MMCONFIG table against the ACPI reserved
> motherboard resources.  If the MMCONFIG table is found to be reserved in
> ACPI, we don't bother checking the E820 table.  The PCI Express firmware
> spec apparently tells BIOS developers that reservation in ACPI is required
> and E820 reservation is optional, so checking against ACPI first makes
> sense.  Many BIOSes don't reserve the MMCONFIG region in E820 even though
> it is perfectly functional, the existing check needlessly disables MMCONFIG
> in these cases.
> In order to do this, MMCONFIG setup has been split into two phases.  If PCI
> configuration type 1 is not available then MMCONFIG is enabled early as
> before.  Otherwise, it is enabled later after the ACPI interpreter is
> enabled, since we need to be able to execute control methods in order to
> check the ACPI reserved resources.  Presently this is just triggered off
> the end of ACPI interpreter initialization.
> There are a few other behavioral changes here:
> - Validate all MMCONFIG configurations provided, not just the first one.
> - Validate the entire required length of each configuration according to
>   the provided ending bus number is reserved, not just the minimum required
>   allocation.
> - Validate that the area is reserved even if we read it from the chipset
>   directly and not from the MCFG table.  This catches the case where the
>   BIOS didn't set the location properly in the chipset and has mapped it
>   over other things it shouldn't have.
> This also cleans up the MMCONFIG initialization functions so that they
> simply do nothing if MMCONFIG is not compiled in.
> Based on an original patch by Rajesh Shah from Intel.

Applied. Thanks,


  parent reply	other threads:[~2008-02-17 14:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15  9:27 Yinghai Lu
2008-02-15  9:28 ` [PATCH 2/5] x86: clear pci_mmcfg_virt when mmcfg get rejected Yinghai Lu
2008-02-15  9:30   ` [PATCH 3/5] x86: mmconf enable mcfg early Yinghai Lu
2008-02-15  9:31     ` [PATCH 4/5] x86_64: check msr to get mmconfig for amd family 10h opteron v3 Yinghai Lu
2008-02-15  9:32       ` [PATCH 5/5] x86_64: set cfg_size for AMD Family 10h in case MMCONFIG is used. v4 Yinghai Lu
2008-02-19  3:59       ` [PATCH 4/5] x86_64: check msr to get mmconfig for amd family 10h opteron v3 Yinghai Lu
2008-02-19 10:13         ` Ingo Molnar
2008-02-19 10:39           ` Yinghai Lu
2008-02-15 11:11 ` [PATCH 1/5] x86: validate against acpi motherboard resources Andi Kleen
2008-02-15 18:46   ` Yinghai Lu
2008-02-15 22:11   ` Yinghai Lu
2008-02-15 22:16     ` Yinghai Lu
2008-02-17 14:06 ` Thomas Gleixner [this message]
     [not found] <fa.LKjQjbOw482S/>
     [not found] ` <>
2008-02-16  5:52   ` Robert Hancock
2008-02-16  6:09     ` Yinghai Lu
2008-02-17 16:42       ` Ingo Molnar
2008-02-18 11:31     ` Andi Kleen
2008-02-18 20:26       ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \
    --cc=Yinghai.Lu@Sun.COM \ \ \ \ \
    --subject='Re: [PATCH 1/5] x86: validate against acpi motherboard resources' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).