LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: RE: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown / disable
Date: Mon, 18 Feb 2008 21:47:15 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802182146020.7583@apollo.tec.linutronix.de> (raw)
In-Reply-To: <600D5CB4DFD93545BF61FF01473D11AC125CC53A@limkexm2.ad.analog.com>

On Mon, 18 Feb 2008, Hennerich, Michael wrote:
> >From: Thomas Gleixner Montag, 18. Februar 2008 18:49
> >+static void default_shutdown(unsigned int irq)
> >+{
> >+	struct irq_desc *desc = irq_desc + irq;
> >+
> >+	desc->chip->mask(irq);
> >+	desc->status &= ~IRQ_MASKED;

Needs to be |= IRQ_MASKED of course. 

Thanks, Michael for pointing it out.

	tglx

  parent reply	other threads:[~2008-02-18 20:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-18 16:58 Hennerich, Michael
2008-02-18 17:49 ` Thomas Gleixner
2008-02-18 18:04   ` Hennerich, Michael
2008-02-18 20:37     ` Thomas Gleixner
2008-02-19  8:58       ` Hennerich, Michael
2008-02-19  9:12         ` Thomas Gleixner
2008-02-18 20:47     ` Thomas Gleixner [this message]
2008-02-19 10:25       ` [BUG][RFC][GENERIC IRQ] linux-2.6.24 (delayed) disable IRQ feature not functional for handle_simple_irq Hennerich, Michael
2008-02-19 10:49         ` Thomas Gleixner
2008-02-19 11:51           ` Hennerich, Michael

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802182146020.7583@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Michael.Hennerich@analog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='RE: [BUG][RFC] [GENERIC IRQ] irq_chip_set_defaults shutdown / disable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).