LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* is "pci_find_subsys" safe to remove?
@ 2008-02-25 22:15 Robert P. J. Day
  2008-02-26  9:19 ` Adrian Bunk
  0 siblings, 1 reply; 3+ messages in thread
From: Robert P. J. Day @ 2008-02-25 22:15 UTC (permalink / raw)
  To: Linux Kernel Mailing List


  it's not just that it falls under the category of PCI "legacy" but,
if you look in drivers/pci/search.c near the bottom:

...
#ifdef CONFIG_PCI_LEGACY
EXPORT_SYMBOL(pci_find_device);
EXPORT_SYMBOL(pci_find_slot);
#endif /* CONFIG_PCI_LEGACY */
...

that symbol is not being exported even *if* you select PCI_LEGACY.
i'm guessing that's an oversight but it would certainly suggest that
no one can possibly be using it, no?

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: is "pci_find_subsys" safe to remove?
  2008-02-25 22:15 is "pci_find_subsys" safe to remove? Robert P. J. Day
@ 2008-02-26  9:19 ` Adrian Bunk
  2008-02-26  9:27   ` Robert P. J. Day
  0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-02-26  9:19 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: Linux Kernel Mailing List

On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
> 
>   it's not just that it falls under the category of PCI "legacy" but,
> if you look in drivers/pci/search.c near the bottom:
> 
> ...
> #ifdef CONFIG_PCI_LEGACY
> EXPORT_SYMBOL(pci_find_device);
> EXPORT_SYMBOL(pci_find_slot);
> #endif /* CONFIG_PCI_LEGACY */
> ...
> 
> that symbol is not being exported even *if* you select PCI_LEGACY.
> i'm guessing that's an oversight but it would certainly suggest that
> no one can possibly be using it, no?

It's used by pci_find_device().

> rday

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: is "pci_find_subsys" safe to remove?
  2008-02-26  9:19 ` Adrian Bunk
@ 2008-02-26  9:27   ` Robert P. J. Day
  0 siblings, 0 replies; 3+ messages in thread
From: Robert P. J. Day @ 2008-02-26  9:27 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Linux Kernel Mailing List

On Tue, 26 Feb 2008, Adrian Bunk wrote:

> On Mon, Feb 25, 2008 at 05:15:25PM -0500, Robert P. J. Day wrote:
> >
> >   it's not just that it falls under the category of PCI "legacy" but,
> > if you look in drivers/pci/search.c near the bottom:
> >
> > ...
> > #ifdef CONFIG_PCI_LEGACY
> > EXPORT_SYMBOL(pci_find_device);
> > EXPORT_SYMBOL(pci_find_slot);
> > #endif /* CONFIG_PCI_LEGACY */
> > ...
> >
> > that symbol is not being exported even *if* you select PCI_LEGACY.
> > i'm guessing that's an oversight but it would certainly suggest that
> > no one can possibly be using it, no?
>
> It's used by pci_find_device().

yes, i noticed that shortly after hitting the ENTER key.  sigh.  it
was a long day ...

rday
--


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-26  9:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-25 22:15 is "pci_find_subsys" safe to remove? Robert P. J. Day
2008-02-26  9:19 ` Adrian Bunk
2008-02-26  9:27   ` Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).