LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64 ia32 syscall restart fix
Date: Fri, 29 Feb 2008 09:03:04 -0800 (PST) [thread overview]
Message-ID: <alpine.LFD.1.00.0802290855230.17889@woody.linux-foundation.org> (raw)
In-Reply-To: <20080229164510.GA6850@elte.hu>
On Fri, 29 Feb 2008, Ingo Molnar wrote:
>
> currently the reality is that i have to fix over 90% of the commit
> messages that go towards you :-/
Heh, yeah. My percentage ends up being much lower, mostly because patches
that come through Andrew are generally already cleaned-up (I edit those
too, but it tends to be one or two per batch, not more than that).
I'm happy you do edit them, because not everybody does, and I do think
it's part of being a subsystem maintainer, but I also end up occasionally
sending emails to the parties involved to try to keep editing to a mimumum
in the future - I personally suspect that it's to a large degree because
people don't think about the effect in the logs..
(Some other projects also tend to have very different models for what a
commit message should look like, so much of it is probably "cultural" too.
I've seen projects that consistently had totally unreadable one-liner
commit messages because (a) nobody ever read them anyway (because the log
just isn't useful when it's per-file) and (b) people were encouraged to
just use things like 'cvs ci -m"Fix bug"' to check in their stuff.
So the kernel is probably fairly odd in generally not asking for any
fixed-format stuff at all (like the GNU changelogs do) but instead writing
a small human-readable novella ;)
Linus
next prev parent reply other threads:[~2008-02-29 17:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 3:57 [PATCH] x86_64 ia32 syscall restart fix Roland McGrath
2008-02-29 15:52 ` Ingo Molnar
2008-02-29 16:26 ` Linus Torvalds
2008-02-29 16:45 ` Ingo Molnar
2008-02-29 17:03 ` Linus Torvalds [this message]
2008-02-29 17:17 ` Ingo Molnar
2008-02-29 17:37 ` Ingo Molnar
2008-02-29 21:02 ` Andrew Morton
2008-02-29 21:20 ` Ingo Molnar
2008-03-01 5:48 ` [stable] " Greg KH
2008-02-29 22:42 ` Roland McGrath
2008-02-29 23:18 ` Linus Torvalds
2008-03-07 22:56 ` [PATCH] x86_64 ptrace orig_ax on ia32 task Roland McGrath
2008-03-07 23:18 ` Linus Torvalds
2008-03-08 1:37 ` Roland McGrath
2008-03-10 19:19 ` Chuck Ebbert
2008-03-10 19:48 ` Linus Torvalds
2008-03-10 20:01 ` Roland McGrath
2008-03-11 9:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.00.0802290855230.17889@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).