LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	Andrew Morton <akpm@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64 ia32 syscall restart fix
Date: Fri, 29 Feb 2008 15:18:23 -0800 (PST)	[thread overview]
Message-ID: <alpine.LFD.1.00.0802291509030.17889@woody.linux-foundation.org> (raw)
In-Reply-To: <20080229224212.24A532700FE@magilla.localdomain>



On Fri, 29 Feb 2008, Roland McGrath wrote:
> 
> I suppose I shouldn't be surprised at being harangued for making my log
> entries too informative.

No, no, no. We want them long and informative. 

The only thing I asked for was that text should have the visual separation 
also between different paragraphs.

I at no point asked you to make the thing shorter, I asked you to split it 
up and MAKE IT VISUALLY LONGER by adding the proper vertical whitespace 
(which is how we do paragraphs).

> If what you want is formulaic log text that always puts blank lines in
> between bug description, change description, and change justification, I
> can do that.  If there is any place that documents the conventions you
> want in log entries, I've overlooked it.

It's _purely_ an issue of overly long paragraphs, not about the language 
or any "formulaic" crap.

The fact is, paragraphs help make things more readable. 

What I find funny is how this email you just wrote actually has *much* 
shorter paragraphs than the changelog entry I replied to. 

Go back and look. The explanation I objected to was a single paragraph, 15 
lines long. That's about two thirds of the screen with no break.

And then, in the email reply you just sent (the one I'm replying to here), 
the longest one was nine lines and most were four or six lines, with one 
being three lines. Why? Because it's simply MORE READABLE.

I didn't ask you to write denser or less readable log messages, I asked 
for exactly the reverse. So I don't understand why you then made your 
reply be a rant about how you could make less explanatory changelog 
messages.

		Linus

  reply	other threads:[~2008-02-29 23:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29  3:57 Roland McGrath
2008-02-29 15:52 ` Ingo Molnar
2008-02-29 16:26   ` Linus Torvalds
2008-02-29 16:45     ` Ingo Molnar
2008-02-29 17:03       ` Linus Torvalds
2008-02-29 17:17         ` Ingo Molnar
2008-02-29 17:37           ` Ingo Molnar
2008-02-29 21:02             ` Andrew Morton
2008-02-29 21:20               ` Ingo Molnar
2008-03-01  5:48                 ` [stable] " Greg KH
2008-02-29 22:42     ` Roland McGrath
2008-02-29 23:18       ` Linus Torvalds [this message]
2008-03-07 22:56 ` [PATCH] x86_64 ptrace orig_ax on ia32 task Roland McGrath
2008-03-07 23:18   ` Linus Torvalds
2008-03-08  1:37     ` Roland McGrath
2008-03-10 19:19   ` Chuck Ebbert
2008-03-10 19:48     ` Linus Torvalds
2008-03-10 20:01       ` Roland McGrath
2008-03-11  9:32         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0802291509030.17889@woody.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH] x86_64 ia32 syscall restart fix' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).