LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH REPOST] [3/3] Replace macro recursion with more conventional loop
Date: Fri, 21 Mar 2008 20:32:46 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.1.00.0803211953520.3781@apollo.tec.linutronix.de> (raw)
In-Reply-To: <20080321171724.GF2346@one.firstfloor.org>

On Fri, 21 Mar 2008, Andi Kleen wrote:
> On Fri, Mar 21, 2008 at 06:07:55PM +0100, Thomas Gleixner wrote:
> > On Tue, 11 Mar 2008, Andi Kleen wrote:
> > > The early exception handlers are currently set up using a macro
> > > recursion. Replace that with a standard loop.
> > > 
> > > Noop patch, just a cleanup.
> > 
> > Cleanups before code changes please.
> 
> It relies on the earlier changes.

I just had a closer look. Your patch order makes sense. It's less
noise that way due to the previous removal of the 3 users of the macro. 

I applied the series with the following changes:

- Moved 3/3 before 2/3 to make it clear that this is a consecutive cleanup
- Simplified 3/3 (patch below)
- fixed the commit log of 3/3 so it points out why the cleanup is done 

Btw, can you please add a "x86:" prefix to your subject lines ?

Thanks,

	tglx
--

The early exception handlers are currently set up using a macro
recursion. There is only one user left. Replace the macro with a
standard loop in place.

--- linux-2.6.orig/arch/x86/kernel/head_64.S
+++ linux-2.6/arch/x86/kernel/head_64.S
@@ -269,15 +269,12 @@ bad_address:
 
 	.section ".init.text","ax"
 #ifdef CONFIG_EARLY_PRINTK
-.macro early_idt_tramp i
-	movl $\i, %esi
-	jmp early_idt_handler
-.endm
 	.globl early_idt_handlers
 early_idt_handlers:
 	i = 0
 	.rept NUM_EXCEPTION_VECTORS
-	early_idt_tramp i
+	movl $i, %esi
+	jmp early_idt_handler
 	i = i + 1
 	.endr
 #endif


  parent reply	other threads:[~2008-03-21 19:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-11  1:23 [PATCH REPOST] [0/3] REPOST: Early exception fixes Andi Kleen
2008-03-11  1:23 ` [PATCH REPOST] [1/3] Don't set up early exception handlers for external interrupts Andi Kleen
2008-03-11  1:23 ` [PATCH REPOST] [2/3] Move early exception handlers into init.text Andi Kleen
2008-03-11  1:23 ` [PATCH REPOST] [3/3] Replace macro recursion with more conventional loop Andi Kleen
2008-03-21 17:07   ` Thomas Gleixner
2008-03-21 17:17     ` Andi Kleen
2008-03-21 17:58       ` Thomas Gleixner
2008-03-21 19:32       ` Thomas Gleixner [this message]
2008-03-11  9:46 ` [PATCH REPOST] [0/3] REPOST: Early exception fixes Thomas Gleixner
  -- strict thread matches above, loose matches on Subject: below --
2008-03-04 21:13 [PATCH REPOST] [1/3] Don't set up early exception handlers for external interrupts Andi Kleen
2008-03-04 21:13 ` [PATCH REPOST] [3/3] Replace macro recursion with more conventional loop Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.1.00.0803211953520.3781@apollo.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --subject='Re: [PATCH REPOST] [3/3] Replace macro recursion with more conventional loop' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).