LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [GIT PULL/RESEND] kernel message catalog patches
Date: Thu, 23 Oct 2008 14:37:24 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0810231433380.3287@nehalem.linux-foundation.org> (raw)
In-Reply-To: <20081023210446.GA12003@osiris.boeblingen.de.ibm.com>



On Thu, 23 Oct 2008, Heiko Carstens wrote:
> 
> The whole point of the patch set is to add documentation for kernel
> messages that are emitted via printk. The documentation is supposed to
> help a sys admin to help understand what went wrong.

I'm still not convinced.

> Please note that this was initially an s390 only patch set but we moved
> the infrastructure to generic code since it looks like others want a
> facility like this too. iirc Andrew requested the move.

I do agree that it makes no sense as a s390 feature, but quite frankly, 
I don't think it makes sense AT ALL. It introduces the notion of fixed 
messages and people now suddenly need to worry about the hashes of the 
contents etc. Exactly the kind of thing that I don't personally EVER want 
to see, and certainly not inside the kernel.

If somebody really wants this, I seriously believe it would be better done 
as a separate out-of-kernel package. Because I don't think it's worth 
maintaining those hashed translations in-kernel, and I'm nto going to ask 
people to even bother.

But if it's in-kernel, other people are then going to complain about them 
not being maintained. And quite frankly, I'm neither willing nor 
interested in hearing those complaints or making them more "valid".

So please keep the kernel message catalog external. Or try to convince me. 
But don't send me a "please pull" without any explanation or any relevant 
convincing argument.

		Linus



  reply	other threads:[~2008-10-23 21:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-16 14:50 [GIT PULL] " Martin Schwidefsky
2008-10-17  7:59 ` Martin Schwidefsky
2008-10-21  9:21   ` [GIT PULL/RESEND] " Heiko Carstens
2008-10-23 15:35     ` Linus Torvalds
2008-10-23 21:04       ` Heiko Carstens
2008-10-23 21:37         ` Linus Torvalds [this message]
2008-10-24 15:50           ` Heiko Carstens
2008-10-26 19:26           ` Martin Schwidefsky
2008-10-26 19:12             ` Linus Torvalds
2008-10-27 10:01               ` Martin Schwidefsky
2008-10-27 15:05                 ` Linus Torvalds
2008-10-27 15:52                   ` Martin Schwidefsky
2008-10-27 16:19                     ` Theodore Tso
2008-10-27 16:27                       ` Randy Dunlap
2008-10-28  8:25                         ` Martin Schwidefsky
2008-10-27 16:03                   ` Alan Cox
2008-10-27 16:10                     ` Linus Torvalds
2008-10-27 16:35                       ` Alan Cox
2008-10-27 19:36                       ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0810231433380.3287@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@suse.de \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --subject='Re: [GIT PULL/RESEND] kernel message catalog patches' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).