LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@elte.hu>,
	Robert Hancock <hancockr@shaw.ca>,
	e1000-devel@lists.sourceforge.net,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.28-rc2 hates my e1000e
Date: Fri, 31 Oct 2008 08:44:52 -0700 (PDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.0810310839380.21084@nehalem.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0810310800120.21084@nehalem.linux-foundation.org>



On Fri, 31 Oct 2008, Linus Torvalds wrote:
> 
> Jonathan, what do things look like with the simple "use 'expand_to_fit'" 
> patch instead, ie something like this:

And by "something like this", I obviously _really_ meant "something 
almost, but not entirely, unlike this".

> -			reserve_region_with_split(&iomem_resource, res->start, res->end, res->name);
> +			insert_resource_expand_to_fit(&iomem_resource, res->start, res->end, res->name);

The "insert_resource_expand_to_fit()" calling convention is much simpler, 
and it should be just

	insert_resource_expand_to_fit(&iomem_resource, res);

which has the downside (?) that it will actually _modify_ the resource as 
it expands it to fit. Of course, it's not like we don't do that in other 
places too (ie the "sanitize" phase), so I don't think it's much of a real 
downside.

Anyway, I'm not appending a fixed patch, becuase the fix is so trivial as 
to be more easily done by hand.

		Linus

  reply	other threads:[~2008-10-31 15:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.P5jmIAOhSJ192sfWD+qlec07fe8@ifi.uio.no>
2008-10-31  0:45 ` Robert Hancock
2008-10-31  2:58   ` Jonathan Corbet
2008-10-31  4:08     ` Yinghai Lu
2008-10-31 15:07       ` Linus Torvalds
2008-10-31 15:44         ` Linus Torvalds [this message]
2008-10-31 16:00           ` Jonathan Corbet
2008-10-31 16:24             ` Linus Torvalds
2008-10-31 16:35               ` Yinghai Lu
2008-10-31 16:46                 ` Linus Torvalds
2008-10-31 16:51               ` Jonathan Corbet
2008-10-31 16:58                 ` Linus Torvalds
2008-10-31 20:20                   ` Yinghai Lu
2008-11-01 15:01                   ` Jonathan Corbet
2008-11-01 17:16                     ` Linus Torvalds
2008-11-01 17:35                       ` Steven Rostedt
2008-11-01 19:50                       ` Yinghai Lu
2008-11-01 22:45                         ` Jonathan Corbet
2008-11-01 22:47                           ` Yinghai Lu
2008-11-01 23:18                           ` Linus Torvalds
2008-11-02  1:26                             ` Robert Hancock
2008-10-30 23:44 Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0810310839380.21084@nehalem.linux-foundation.org \
    --to=torvalds@linux-foundation.org \
    --cc=corbet@lwn.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yinghai@kernel.org \
    --subject='Re: 2.6.28-rc2 hates my e1000e' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).