LKML Archive on
help / color / mirror / Atom feed
From: Linus Torvalds <>
To: Al Viro <>
Subject: Re: [RFC][PATCH] saner FASYNC handling on file close
Date: Sat, 1 Nov 2008 09:49:24 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 31 Oct 2008, Al Viro wrote:
> 	As it is, all instances of ->release() for files that have
> ->fasync() need to remember to evict file from fasync lists; forgetting
> that creates a hole and we actually have a bunch that *does* forget.
> 	So let's keep our lives simple - let __fput() check FASYNC in
> file->f_flags and call ->fasync() there if it's been set.  And lose
> that crap in ->release() instances - leaving it there is still valid,
> but we don't have to bother anymore.
> Comments?

This looks like "obviously the right thing". Done.


      reply	other threads:[~2008-11-01 16:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31 23:28 Al Viro
2008-11-01 16:49 ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \
    --subject='Re: [RFC][PATCH] saner FASYNC handling on file close' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).