From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755281Ab1AaKXf (ORCPT ); Mon, 31 Jan 2011 05:23:35 -0500 Received: from www.tglx.de ([62.245.132.106]:39095 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755020Ab1AaKXd (ORCPT ); Mon, 31 Jan 2011 05:23:33 -0500 Date: Mon, 31 Jan 2011 11:23:21 +0100 (CET) From: Thomas Gleixner To: Torben Hohn cc: LKML , Peter Zijlstra , johnstul@us.ibm.com, hch@infradead.org, yong.zhang0@gmail.com, Matt Turner , Richard Henderson Subject: Re: [PATCH v2 05/20] alpha: change do_timer() to xtime_update() In-Reply-To: <20110127145915.23248.20919.stgit@localhost> Message-ID: References: <20110127145741.23248.68098.stgit@localhost> <20110127145915.23248.20919.stgit@localhost> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 27 Jan 2011, Torben Hohn wrote: > xtime_update() takes the xtime_lock itself. > state does not to be protected with this lock. > its only touched here and during init. xtime_lock very well serializes the access to state on SMP. timer_interrupt() is called on each cpu. So that wont work. Thanks, tglx