LKML Archive on
help / color / mirror / Atom feed
From: Thomas Gleixner <>
To: Guan Xuetao <>
Cc:, Arnd Bergmann <>,,,,,,,
Subject: Re: Request (2nd) for unicore32 architecture codes to merge into linux-next
Date: Sun, 6 Feb 2011 23:06:13 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1102062254560.31804@localhost6.localdomain6> (raw)
In-Reply-To: <01c701cbba0f$08185800$18490800$>

On Sat, 22 Jan 2011, Guan Xuetao wrote:

> Hi, I want to merge unicore32 repo into linux-next tree, the
> position is (unicore32 branch):

Sorry for late reply.
>  arch/unicore32/kernel/time.c                  |  148 +++++

static struct clock_event_device ckevt_puv3_osmr0 ...
        .shift          = 18, /* correct shift val: 16, but warn_on_slowpath */
        .shift          = 30,

        ckevt_puv3_osmr0.mult =
                div_sc(CLOCK_TICK_RATE, NSEC_PER_SEC, ckevt_puv3_osmr0.shift);

Please use the function which calculates the optimizes mult/shift
values for you depending on the clock frequency.

clockevents_calc_mult_shift() is your friend.

>  arch/unicore32/kernel/irq.c                   |  426 +++++++++++++

Please convert your irq_chips to the new function pointers:

       .mask -> .irq_mask

The new functions replace the "unsigned int irq" argument with
"struct irq_data *d".

So conversion for your chips is simply

s/unsigned int irq/struct irq_data *d/


s/irq/d->irq/ in the implementation.

Then your arch should select: GENERIC_HARDIRQS_NO_DEPRECATED

Otherwise I'm happy with your irq and time related patches.



  reply	other threads:[~2011-02-06 22:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-22  8:33 Guan Xuetao
2011-02-06 22:06 ` Thomas Gleixner [this message]
2011-02-11  3:18   ` Guan Xuetao
2011-01-22 13:52 Xuetao Guan
2011-01-22 22:46 ` Stephen Rothwell
2011-01-24  2:50   ` Guan Xuetao
2011-01-31 22:38 ` Stephen Rothwell
2011-02-01  5:05   ` Guan Xuetao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1102062254560.31804@localhost6.localdomain6 \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: Request (2nd) for unicore32 architecture codes to merge into linux-next' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).