LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Greg Ungerer <gerg@snapgear.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Greg Ungerer <gerg@uclinux.org>
Subject: Re: [patch 07/10] m68knommu: Convert 5272 intc irq_chip to new functions
Date: Tue, 8 Feb 2011 10:48:31 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1102081047020.31804@localhost6.localdomain6> (raw)
In-Reply-To: <4D50B773.2070507@snapgear.com>

On Tue, 8 Feb 2011, Greg Ungerer wrote:
> >  static void intc_external_irq(unsigned int irq, struct irq_desc *desc)
> >  {
> > -	desc->chip->ack(irq);
> > +	get_irq_desc_chip(i)->irq_ack(desc->irq_data);
>                          ^^^         ^^^
> should this be:
> 
>         get_irq_desc_chip(desc)->irq_ack(&desc->irq_data)

Yes.
 
> I can't runtime test this right at the moment, but otherwise:
> 
> Acked-by: Greg Ungerer <gerg@uclinux.org>

Can you push that stuff linus wards for 39 or want me to do it ? It
has no dependencies whatsoever.

Thanks,

	tglx



  reply	other threads:[~2011-02-08  9:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-06 23:39 [patch 00/10] m68knommu: Convert irq_chips and use proper accessor functions Thomas Gleixner
2011-02-06 23:39 ` [patch 01/10] m68knommu: 5772: Replace private irq flow handler Thomas Gleixner
2011-02-08  4:49   ` Greg Ungerer
2011-02-08  4:52   ` Greg Ungerer
2011-02-06 23:39 ` [patch 02/10] m68knommu Convert coldfire intc irq_chip to new functions Thomas Gleixner
2011-02-06 23:39 ` [patch 03/10] m68knommu: Convert coldfire intc-2 " Thomas Gleixner
2011-02-06 23:39 ` [patch 04/10] m68knommu: Convert coldfire intc-simr " Thomas Gleixner
2011-02-06 23:39 ` [patch 05/10] m68knommu: Convert 68328 ints " Thomas Gleixner
2011-02-06 23:39 ` [patch 06/10] m68knommu: Convert 68360 " Thomas Gleixner
2011-02-06 23:39 ` [patch 07/10] m68knommu: Convert 5272 intc " Thomas Gleixner
2011-02-08  3:24   ` Greg Ungerer
2011-02-08  9:48     ` Thomas Gleixner [this message]
2011-02-08 10:03       ` Greg Ungerer
2011-02-06 23:39 ` [patch 08/10] m68knommu Convert 5249 " Thomas Gleixner
2011-02-06 23:39 ` [patch 09/10] m68knommu: Use proper irq_desc accessors in show_interrupts() Thomas Gleixner
2011-02-06 23:39 ` [patch 10/10] m68knommu: Select GENERIC_HARDIRQS_NO_DEPRECATED Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1102081047020.31804@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=gerg@snapgear.com \
    --cc=gerg@uclinux.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [patch 07/10] m68knommu: Convert 5272 intc irq_chip to new functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).