LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Gregory Bean <gbean@codeaurora.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jean Delvare <khali@linux-fr.org>,
	Lennert Buytenhek <buytenh@secretlab.ca>,
	rvaswani@codeaurora.org
Subject: Re: [patch] drivers: gpio: sx150x: Do not access I2C from mask/unmask functions
Date: Mon, 14 Feb 2011 20:58:47 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.00.1102142058330.26192@localhost6.localdomain6> (raw)
In-Reply-To: <20110214194546.GA10940@gbean-linux.qualcomm.com>

On Mon, 14 Feb 2011, Gregory Bean wrote:

> >  static int sx150x_irq_set_type(struct irq_data *d, unsigned int flow_type)
> > @@ -350,7 +353,7 @@ static int sx150x_irq_set_type(struct ir
> >  
> >  	chip->irq_sense &= ~(3UL << (n * 2));
> >  	chip->irq_sense |= val << (n * 2);
> > -	chip->irq_set_type_pending |= BIT(n);
> > +	chip->update = n;
> 
> Should this be irq_update?

See reply to myself

      reply	other threads:[~2011-02-14 19:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 16:48 Thomas Gleixner
2011-02-14 17:08 ` Thomas Gleixner
2011-02-16  2:48   ` Grant Likely
2011-02-14 19:45 ` Gregory Bean
2011-02-14 19:58   ` Thomas Gleixner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1102142058330.26192@localhost6.localdomain6 \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=buytenh@secretlab.ca \
    --cc=gbean@codeaurora.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rvaswani@codeaurora.org \
    --subject='Re: [patch] drivers: gpio: sx150x: Do not access I2C from mask/unmask functions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).