LKML Archive on
help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <>
To: David Daney <>
	Leonid Yegoshin <>,
	Markos Chandras <>,
	David Daney <>
Subject: Re: [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction"
Date: Tue, 24 Feb 2015 01:10:58 +0000 (GMT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, 23 Feb 2015, David Daney wrote:

> From: David Daney <>
> This reverts commit 77f3ee59ee7cfe19e0ee48d9a990c7967fbfcbed.
> There are two problems:
> 1) It breaks OCTEON, which will now crash in early boot with:
>   Kernel panic - not syncing: No TLB refill handler yet (CPU type: 80)
> 2) The logic is broken.
> The meaning of cpu_has_mips_r2_exec_hazard is that the EHB instruction
> is required.  The offending patch attempts (and fails) to change the
> meaning to be that EHB is part of the ISA.
> Signed-off-by: David Daney <>
> ---

 Code affected will have to be reconsidered including possibly older 
changes as well.  Meanwhile, to revert the immediate regression, you have 

Reviewed-by: Maciej W. Rozycki <>

Next time please try to use the imperative mood for the commit message 
though, as per Documentation/SubmittingPatches.

 Overall I think it makes sense to have a look back there every once in a 
while to avoid getting trapped in routine.  Some breakage we fall into 
from time to time results from missing the guidelines set there, sigh.


  reply	other threads:[~2015-02-24  1:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 22:52 [PATCH] Revert "MIPS: mm: tlbex: Use cpu_has_mips_r2_exec_hazard for the EHB instruction" David Daney
2015-02-24  1:10 ` Maciej W. Rozycki [this message]
2015-03-11  8:28 ` Markos Chandras
2015-03-11 16:51   ` David Daney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).