LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jesper Juhl <jesper.juhl@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>,
	Trivial patch monkey <trivial@kernel.org>
Subject: Re: firmware_sample_driver.c: fix coding style
Date: Mon, 21 Apr 2008 23:49:10 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LNX.1.00.0804212348230.1777@dragon.funnycrock.com> (raw)
In-Reply-To: <20080401105546.GA10714@elf.ucw.cz>

On Tue, 1 Apr 2008, Pavel Machek wrote:

> Fix coding style in firmware_sample_driver...
> 
> Signed-off-by: Pavel Machek <pavel@suse.cz>
> 

I've added this patch to the trivial tree.
Thanks Pavel.

/Jesper Juhl



> diff --git a/Documentation/firmware_class/firmware_sample_driver.c b/Documentation/firmware_class/firmware_sample_driver.c
> index 6865cbe..600cdd9 100644
> --- a/Documentation/firmware_class/firmware_sample_driver.c
> +++ b/Documentation/firmware_class/firmware_sample_driver.c
> @@ -34,8 +34,7 @@ static void sample_probe_default(void)
>          const struct firmware *fw_entry;
>  	printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
>  
> -        if(request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0)
> -	{
> +        if (request_firmware(&fw_entry, "sample_driver_fw", &ghost_device)!=0) {
>  		printk(KERN_ERR
>  		       "firmware_sample_driver: Firmware not available\n");
>  		return;
> @@ -56,8 +55,7 @@ static void sample_probe_specific(void)
>  
>  	printk(KERN_INFO "firmware_sample_driver: a ghost device got inserted :)\n");
>  
> -        if(request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0)
> -	{
> +        if (request_firmware(NULL, "sample_driver_fw", &ghost_device)!=0) {
>  		printk(KERN_ERR
>  		       "firmware_sample_driver: Firmware load failed\n");
>  		return;
> @@ -70,7 +68,7 @@ static void sample_probe_specific(void)
>  }
>  static void sample_probe_async_cont(const struct firmware *fw, void *context)
>  {
> -	if(!fw){
> +	if (!fw) {
>  		printk(KERN_ERR
>  		       "firmware_sample_driver: firmware load failed\n");
>  		return;
> @@ -88,9 +86,8 @@ static void sample_probe_async(void)
>  					 "sample_driver_fw", &ghost_device,
>  					 "my device pointer",
>  					 sample_probe_async_cont);
> -	if(error){
> -		printk(KERN_ERR 
> -		       "firmware_sample_driver:"
> +	if (error) {
> +		printk(KERN_ERR "firmware_sample_driver:"
>  		       " request_firmware_nowait failed\n");
>  	}
>  }
> @@ -105,6 +102,7 @@ static int sample_init(void)
>  	sample_probe_async();
>  	return 0;
>  }
> +
>  static void __exit sample_exit(void)
>  {
>  }
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 

      reply	other threads:[~2008-04-21 21:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-01 10:55 Pavel Machek
2008-04-21 21:49 ` Jesper Juhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.1.00.0804212348230.1777@dragon.funnycrock.com \
    --to=jesper.juhl@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=trivial@kernel.org \
    --subject='Re: firmware_sample_driver.c: fix coding style' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).