LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Use single threaded work queue for hid_compat
@ 2008-11-10 21:51 Andi Kleen
2008-11-11 22:41 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Andi Kleen @ 2008-11-10 21:51 UTC (permalink / raw)
To: jkosina, linux-kernel
Use single threaded work queue for hid_compat
I doubt HID really needs to scale over multiple CPUs. So only use a
single threaded workqueue for HID_COMPAT. This avoids some excessive
thread use on systems with a larger number of CPUs.
Should still go into 2.6.28 if possible.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
drivers/hid/hid-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.28-rc4-test/drivers/hid/hid-core.c
===================================================================
--- linux-2.6.28-rc4-test.orig/drivers/hid/hid-core.c 2008-11-06 20:26:34.000000000 +0100
+++ linux-2.6.28-rc4-test/drivers/hid/hid-core.c 2008-11-10 22:36:49.000000000 +0100
@@ -1729,7 +1729,7 @@
goto err_bus;
#ifdef CONFIG_HID_COMPAT
- hid_compat_wq = create_workqueue("hid_compat");
+ hid_compat_wq = create_singlethread_workqueue("hid_compat");
if (!hid_compat_wq) {
hidraw_exit();
goto err;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Use single threaded work queue for hid_compat
2008-11-10 21:51 [PATCH] Use single threaded work queue for hid_compat Andi Kleen
@ 2008-11-11 22:41 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2008-11-11 22:41 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel
On Mon, 10 Nov 2008, Andi Kleen wrote:
> I doubt HID really needs to scale over multiple CPUs. So only use a
> single threaded workqueue for HID_COMPAT. This avoids some excessive
> thread use on systems with a larger number of CPUs.
Yes, makes sense, thanks. Applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-11 22:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-10 21:51 [PATCH] Use single threaded work queue for hid_compat Andi Kleen
2008-11-11 22:41 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).