Re: [PATCH 4/8] HID: roccat: Add support for Kova[+] mouse

[Jiri Kosina <jkosina@suse.cz>]

On Sun, 30 Jan 2011, Stefan Achatz wrote:

> This patch adds support for Roccat Kova[+] mouse.
> Userland tools can soon be found at http://sourceforge.net/projects/roccat
> 
> Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
> ---
>  .../ABI/testing/sysfs-driver-hid-roccat-kovaplus   |   91 +++
>  drivers/hid/Kconfig                                |    8 +
>  drivers/hid/Makefile                               |    1 +
>  drivers/hid/hid-core.c                             |    1 +
>  drivers/hid/hid-ids.h                              |    1 +
>  drivers/hid/hid-roccat-kovaplus.c                  |  715 ++++++++++++++++++++
>  drivers/hid/hid-roccat-kovaplus.h                  |  157 +++++
>  7 files changed, 974 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-hid-roccat-kovaplus
>  create mode 100644 drivers/hid/hid-roccat-kovaplus.c
>  create mode 100644 drivers/hid/hid-roccat-kovaplus.h
> 
> diff --git a/Documentation/ABI/testing/sysfs-driver-hid-roccat-kovaplus b/Documentation/ABI/testing/sysfs-driver-hid-roccat-kovaplus
> new file mode 100644
> index 0000000..9e54af4
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-driver-hid-roccat-kovaplus
> @@ -0,0 +1,91 @@
> +What:		/sys/bus/usb/devices/<busnum>-<devnum>:<config num>.<interface num>/<hid-bus>:<vendor-id>:<product-id>.<num>/kovaplus/roccatkovaplus<minor>/actual_cpi
> +Date:		January 2011
> +Contact:	Stefan Achatz <erazor_de@users.sourceforge.net>
> +Description:	The integer value of this attribute ranges from 1-4.
> +		When read, this attribute returns the number of the active
> +		cpi level.
> +		This file is readonly.
> +

Stefan, one more things comes to my mind here.

Could you please post a followup patch with 'Users:' tag included in the 
sysfs documentation, pointing to the userspace application/library?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.