LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jesper Juhl <jj@chaosbits.net>
To: linux-nfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Neil Brown <neilb@suse.de>,
bfields@fieldses.org
Subject: [PATCH] Fix size argument to memset call in nfsacl_encode
Date: Thu, 3 Feb 2011 20:15:28 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1102032012540.15101@swampdragon.chaosbits.net> (raw)
We want to give memset() the sizeof(struct posix_acl), not
sizeof(struct posix_acl *).
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
nfsacl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
index 84c27d6..bc6d81b 100644
--- a/fs/nfs_common/nfsacl.c
+++ b/fs/nfs_common/nfsacl.c
@@ -117,7 +117,7 @@ int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode,
* invoked in contexts where a memory allocation failure is
* fatal. Fortunately this fake ACL is small enough to
* construct on the stack. */
- memset(acl2, 0, sizeof(acl2));
+ memset(acl2, 0, sizeof(*acl2));
posix_acl_init(acl2, 4);
/* Insert entries in canonical order: other orders seem
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
next reply other threads:[~2011-02-03 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 19:15 Jesper Juhl [this message]
2011-02-03 19:28 ` Trond Myklebust
2011-02-03 19:41 ` Jesper Juhl
2011-02-03 20:00 ` Chuck Lever
2011-02-03 20:06 ` Trond Myklebust
2011-02-03 20:29 ` Chuck Lever
2011-02-03 21:55 ` Trond Myklebust
2011-02-23 22:26 ` Jesper Juhl
2011-02-23 22:27 ` Jesper Juhl
2011-02-04 0:37 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1102032012540.15101@swampdragon.chaosbits.net \
--to=jj@chaosbits.net \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--subject='Re: [PATCH] Fix size argument to memset call in nfsacl_encode' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).