LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Jiri Kosina <jkosina@suse.cz>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive
Date: Tue, 17 Feb 2015 13:24:18 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1502171323420.2279@pobox.suse.cz> (raw)
In-Reply-To: <20150129200950.GC27265@mail.corp.redhat.com>
On Thu, 29 Jan 2015, Benjamin Tissoires wrote:
> > The Microsoft HID over I2C specification says two things regarding the
> > interrupt:
> >
> > 1) The interrupt should be level sensitive
> > 2) The device keeps the interrupt asserted as long as it has more reports
> > available.
> >
> > We've seen that at least some Atmel and N-Trig panels keep the line low as
> > long as they have something to send. The current version of the driver only
> > detects the first edge but then fails to read rest of the reports (as the
> > line is still asserted).
> >
> > Make the driver follow the specification and configure the HID interrupt to
> > be level sensitive.
> >
> > The Windows HID over I2C driver also seems to do the same.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
>
> FWIW, this one is
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> looks like we are going to drop 2/2, but this one is still valid.
Applied to for-3.20/upstream-fixes, thanks for your friendly ping in form
of Ack :)
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2015-02-17 12:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 14:29 [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive Mika Westerberg
2015-01-26 14:29 ` [PATCH 2/2] HID: i2c-hid: Add support for GPIO interrupts Mika Westerberg
2015-01-26 14:37 ` Mark Rutland
2015-01-26 14:47 ` Mika Westerberg
2015-01-26 14:50 ` Mark Rutland
2015-01-26 15:16 ` Mika Westerberg
2015-01-26 16:01 ` Mark Rutland
2015-01-26 16:13 ` Mika Westerberg
2015-01-26 16:39 ` Mark Rutland
2015-01-27 10:16 ` Mika Westerberg
2015-01-27 10:39 ` Mark Rutland
2015-01-27 10:59 ` Mika Westerberg
2015-01-27 11:14 ` Mark Rutland
2015-01-27 11:30 ` Mika Westerberg
2015-01-27 14:33 ` Mark Rutland
2015-01-27 14:41 ` Mika Westerberg
2015-01-27 15:06 ` Mark Rutland
2015-01-27 15:21 ` Mika Westerberg
2015-01-27 15:57 ` Mark Rutland
2015-01-27 17:10 ` Mika Westerberg
2015-01-29 20:09 ` [PATCH 1/2] HID: i2c-hid: The interrupt should be level sensitive Benjamin Tissoires
2015-02-17 12:24 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1502171323420.2279@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).