LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	linux-m68k@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] macmace: Set platform device coherent_dma_mask
Date: Thu, 3 May 2018 18:38:21 +1000 (AEST)	[thread overview]
Message-ID: <alpine.LNX.2.21.1805031801310.8@nippy.intranet> (raw)
In-Reply-To: <CAMuHMdUAxmVZLekekvVrnMbbL18oyY86sF9QX087idSqcKMiPQ@mail.gmail.com>

On Thu, 3 May 2018, Geert Uytterhoeven wrote:

> > --- a/drivers/net/ethernet/apple/macmace.c
> > +++ b/drivers/net/ethernet/apple/macmace.c
> > @@ -203,6 +203,10 @@ static int mace_probe(struct platform_device *pdev)
> >         unsigned char checksum = 0;
> >         int err;
> >
> > +       err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> > +       if (err)
> > +               return err;
> > +
> >         dev = alloc_etherdev(PRIV_BYTES);
> >         if (!dev)
> >                 return -ENOMEM;
> 
> Shouldn't this be handled in the platform code that instantiates the 
> device, i.e. in arch/m68k/mac/config.c:mac_platform_init()?
> 

I wondered about that too. The downside is that I'd have to convert 
platform_device_register_simple() into platform_device_register() and add 
all of the boilerplate that goes with that, for little gain.

> Cfr. commit f61e64310b75733d ("m68k: set dma and coherent masks for 
> platform FEC ethernets").
> 

Yes, I looked at that patch before I sent this one. It makes sense to set 
the mask when defining the device since some devices tend to have inherent 
limitations (but that's not really applicable here).

Moreover, it turns out that a number of platform drivers already call 
dma_set_mask_and_coherent() or dma_coerce_mask_and_coherent() or similar.

I figured that platform drivers aren't expected to be particularly 
portable. Well, I'd expect macmace and macsonic to be portable to NuBus 
PowerMacs, but AFAIK the correct mask would remain DMA_BIT_MASK(32).

So that's how I ended up with this patch. But if you are not pursuaded by 
my reasoning then just say the word and I'll take another approach.

-- 

> Gr{oetje,eeting}s,
> 
>                         Geert
> 

  reply	other threads:[~2018-05-03  8:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <S1751632AbeECEYA/20180503042400Z+254@vger.kernel.org>
2018-05-03  7:25 ` Geert Uytterhoeven
2018-05-03  8:38   ` Finn Thain [this message]
2018-05-03  8:46     ` Geert Uytterhoeven
2018-05-03  8:51       ` Christoph Hellwig
2018-05-03 20:24         ` Michael Schmitz
2018-05-04  7:24           ` Geert Uytterhoeven
2018-05-04  8:16             ` Michael Schmitz
2018-05-10  1:25         ` Finn Thain
2018-05-10  1:25       ` Finn Thain
2018-05-10 20:27         ` Michael Schmitz
2018-05-10 23:55           ` Finn Thain
2018-05-11  2:11             ` Michael Schmitz
2018-05-11  3:28               ` Finn Thain
2018-05-11  4:18                 ` Michael Schmitz
2018-05-11  5:28                   ` Finn Thain
2018-05-11  9:30                     ` Michael Schmitz
2018-05-11 10:06                       ` Finn Thain
2018-05-11 22:02                         ` Michael Schmitz
2018-05-03  4:23 Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.21.1805031801310.8@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCH net] macmace: Set platform device coherent_dma_mask' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).