LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] selinux: recognize netlink messages for 'ip addrlabel'
@ 2008-11-05 12:35 Michal Schmidt
2008-11-05 14:05 ` Stephen Smalley
2008-11-05 23:09 ` James Morris
0 siblings, 2 replies; 3+ messages in thread
From: Michal Schmidt @ 2008-11-05 12:35 UTC (permalink / raw)
To: James Morris; +Cc: linux-kernel, Eric Paris, netdev
In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux: unrecognized
netlink message type=74 for sclass=43
The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
message types table.
Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
security/selinux/nlmsgtab.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
index ff59c0c..4ed7bab 100644
--- a/security/selinux/nlmsgtab.c
+++ b/security/selinux/nlmsgtab.c
@@ -63,6 +63,9 @@ static struct nlmsg_perm nlmsg_route_perms[] =
{ RTM_GETANYCAST, NETLINK_ROUTE_SOCKET__NLMSG_READ },
{ RTM_GETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
{ RTM_SETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
+ { RTM_NEWADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
+ { RTM_DELADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
+ { RTM_GETADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
};
static struct nlmsg_perm nlmsg_firewall_perms[] =
--
1.6.0.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'
2008-11-05 12:35 [PATCH] selinux: recognize netlink messages for 'ip addrlabel' Michal Schmidt
@ 2008-11-05 14:05 ` Stephen Smalley
2008-11-05 23:09 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Smalley @ 2008-11-05 14:05 UTC (permalink / raw)
To: Michal Schmidt; +Cc: James Morris, linux-kernel, Eric Paris, netdev
On Wed, 2008-11-05 at 13:35 +0100, Michal Schmidt wrote:
> In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
> type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux: unrecognized
> netlink message type=74 for sclass=43
>
> The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
> message types table.
>
> Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
> security/selinux/nlmsgtab.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/security/selinux/nlmsgtab.c b/security/selinux/nlmsgtab.c
> index ff59c0c..4ed7bab 100644
> --- a/security/selinux/nlmsgtab.c
> +++ b/security/selinux/nlmsgtab.c
> @@ -63,6 +63,9 @@ static struct nlmsg_perm nlmsg_route_perms[] =
> { RTM_GETANYCAST, NETLINK_ROUTE_SOCKET__NLMSG_READ },
> { RTM_GETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
> { RTM_SETNEIGHTBL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> + { RTM_NEWADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> + { RTM_DELADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_WRITE },
> + { RTM_GETADDRLABEL, NETLINK_ROUTE_SOCKET__NLMSG_READ },
> };
>
> static struct nlmsg_perm nlmsg_firewall_perms[] =
--
Stephen Smalley
National Security Agency
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] selinux: recognize netlink messages for 'ip addrlabel'
2008-11-05 12:35 [PATCH] selinux: recognize netlink messages for 'ip addrlabel' Michal Schmidt
2008-11-05 14:05 ` Stephen Smalley
@ 2008-11-05 23:09 ` James Morris
1 sibling, 0 replies; 3+ messages in thread
From: James Morris @ 2008-11-05 23:09 UTC (permalink / raw)
To: Michal Schmidt; +Cc: linux-kernel, Eric Paris, netdev
On Wed, 5 Nov 2008, Michal Schmidt wrote:
> In enforcing mode '/sbin/ip addrlabel' results in a SELinux error:
> type=SELINUX_ERR msg=audit(1225698822.073:42): SELinux: unrecognized
> netlink message type=74 for sclass=43
>
> The problem is missing RTM_*ADDRLABEL entries in SELinux's netlink
> message types table.
>
> Reported in https://bugzilla.redhat.com/show_bug.cgi?id=469423
>
> Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
> ---
> security/selinux/nlmsgtab.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-05 23:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-05 12:35 [PATCH] selinux: recognize netlink messages for 'ip addrlabel' Michal Schmidt
2008-11-05 14:05 ` Stephen Smalley
2008-11-05 23:09 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).