LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Michal Hocko <mhocko@kernel.org>,
	David Rientjes <rientjes@google.com>,
	dm-devel@redhat.com, eric.dumazet@gmail.com,
	netdev@vger.kernel.org, jasowang@redhat.com,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org,
	Matthew Wilcox <willy@infradead.org>,
	linux-mm@kvack.org, edumazet@google.com,
	Andrew Morton <akpm@linux-foundation.org>,
	virtualization@lists.linux-foundation.org,
	David Miller <davem@davemloft.net>,
	Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options
Date: Thu, 26 Apr 2018 12:07:25 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LRH.2.02.1804261202350.24656@file01.intranet.prod.int.rdu2.redhat.com> (raw)
In-Reply-To: <20180426184845-mutt-send-email-mst@kernel.org>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2389 bytes --]



On Thu, 26 Apr 2018, Michael S. Tsirkin wrote:

> On Thu, Apr 26, 2018 at 11:44:21AM -0400, Mikulas Patocka wrote:
> > 
> > 
> > On Thu, 26 Apr 2018, James Bottomley wrote:
> > 
> > > On Thu, 2018-04-26 at 11:05 -0400, Mikulas Patocka wrote:
> > > > 
> > > > On Thu, 26 Apr 2018, James Bottomley wrote:
> > > [...]
> > > > > Perhaps find out beforehand instead of insisting on an approach
> > > > without
> > > > > knowing.  On openSUSE the grub config is built from the files in
> > > > > /etc/grub.d/ so any package can add a kernel option (and various
> > > > > conditions around activating it) simply by adding a new file.
> > > > 
> > > > And then, different versions of the debug kernel will clash when 
> > > > attempting to create the same file.
> > > 
> > > Don't be silly ... there are many ways of coping with that in rpm/dpkg.
> > 
> > I know you can deal with it - but how many lines of code will that 
> > consume? Multiplied by the total number of rpm-based distros.
> > 
> > Mikulas
> 
> I don't think debug kernels should inject faults by default.

But it is not injecting any faults. It is using the fault-injection 
framework because Michal said that it should use it. The original version 
of the patch didn't use the fault-injection framework at all.

The kvmalloc function can take two branches, the kmalloc branch and 
vmalloc branch. The vmalloc branch is taken rarely, so the kernel contains 
bugs regarding this path - and the patch increases the probability that 
the vmalloc patch is taken, to discover the bugs early and make them 
reproducible.

> IIUC debug kernels mainly exist so people who experience e.g. memory
> corruption can try and debug the failure. In this case, CONFIG_DEBUG_SG
> will *already* catch a failure early. Nothing special needs to be done.

The patch helps people debug such memory coprruptions (such as using DMA 
API on the result of kvmalloc).

> There is a much smaller class of people like QA who go actively looking
> for trouble. That's the kind of thing fault injection is good for, and
> IMO you do not want your QA team to test a separate kernel - otherwise
> you are never quite sure whatever was tested will work in the field.
> So a config option won't help them either.
> 
> How do you make sure QA tests a specific corner case? Add it to
> the test plan :)
> 
> I don't speak for Red Hat, etc.
> 
> -- 
> MST

Mikulas

  reply	other threads:[~2018-04-26 16:07 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 14:34 [PATCH] net: don't use kvzalloc for DMA memory Mikulas Patocka
2018-04-18 16:05 ` Eric Dumazet
2018-04-18 16:44   ` Mikulas Patocka
2018-04-18 16:51     ` Eric Dumazet
2018-04-18 17:47       ` David Miller
2018-04-18 17:55         ` Mikulas Patocka
2018-04-18 18:00         ` Michael S. Tsirkin
2018-04-18 17:49       ` Mikulas Patocka
2018-04-18 17:46     ` David Miller
2018-04-18 17:53       ` Mikulas Patocka
2018-04-19 16:12         ` [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM Mikulas Patocka
2018-04-19 16:25           ` Eric Dumazet
2018-04-19 16:28             ` Mikulas Patocka
2018-04-19 16:43           ` Michael S. Tsirkin
2018-04-19 21:27             ` [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG Mikulas Patocka
2018-04-19 18:28           ` [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM Vlastimil Babka
2018-04-19 19:47           ` Andrew Morton
2018-04-19 21:19             ` Mikulas Patocka
2018-04-19 23:22               ` Andrew Morton
2018-04-20 12:16                 ` Mikulas Patocka
2018-04-20 11:47           ` Matthew Wilcox
2018-04-20 12:20             ` Mikulas Patocka
2018-04-23 15:25               ` Michael S. Tsirkin
2018-04-20 13:08           ` Michal Hocko
2018-04-20 13:41             ` Matthew Wilcox
2018-04-20 13:49               ` Michal Hocko
2018-04-20 20:56                 ` Mikulas Patocka
2018-04-20 20:54             ` Mikulas Patocka
2018-04-20 21:02               ` Matthew Wilcox
2018-04-20 21:21                 ` Mikulas Patocka
2018-04-21 14:47                   ` Matthew Wilcox
2018-04-22 13:03                     ` Michal Hocko
2018-04-23 14:24                       ` Mikulas Patocka
2018-04-23 15:10                         ` Michal Hocko
2018-04-23 23:20                           ` Mikulas Patocka
2018-04-23 14:06                     ` Mikulas Patocka
2018-04-23 15:15                       ` Michal Hocko
2018-04-24  0:06                         ` [PATCH v3] kvmalloc: always use vmalloc if CONFIG_DEBUG_SG Mikulas Patocka
2018-04-24  2:47                           ` David Rientjes
2018-04-24 11:04                             ` Mikulas Patocka
2018-04-24  3:46                           ` Matthew Wilcox
2018-04-24 12:29                             ` Mikulas Patocka
2018-04-24 17:16                               ` Matthew Wilcox
2018-04-24 18:41                                 ` Mikulas Patocka
2018-05-15  1:13                                   ` Joonsoo Kim
2018-04-24 12:51                           ` Michal Hocko
2018-04-24 15:50                             ` Mikulas Patocka
2018-04-24 16:29                               ` Michal Hocko
2018-04-24 17:00                                 ` Mikulas Patocka
2018-04-24 17:03                                   ` Michal Hocko
2018-04-24 17:28                                     ` Mikulas Patocka
2018-04-24 17:38                                       ` Michal Hocko
2018-04-25 20:02                                         ` [PATCH] fault-injection: reorder config entries Mikulas Patocka
2018-04-26  3:21                                           ` Randy Dunlap
2018-04-25 20:02                                         ` [PATCH v4] fault-injection: introduce kvmalloc fallback options Mikulas Patocka
2018-04-25 20:20                                           ` Randy Dunlap
2018-04-25 20:57                                             ` [PATCH v5] " Mikulas Patocka
2018-04-25 21:11                                               ` Randy Dunlap
2018-04-25 21:18                                               ` David Rientjes
2018-04-25 21:22                                                 ` Mikulas Patocka
2018-04-25 22:17                                                   ` [dm-devel] " James Bottomley
2018-04-25 22:42                                                     ` Mikulas Patocka
2018-04-25 22:49                                                       ` David Rientjes
2018-04-25 22:56                                                         ` Mikulas Patocka
2018-04-26 12:58                                                       ` Michal Hocko
2018-04-26 14:28                                                         ` Mikulas Patocka
2018-04-26 14:45                                                           ` James Bottomley
2018-04-26 15:05                                                             ` Mikulas Patocka
2018-04-26 15:24                                                               ` James Bottomley
2018-04-26 15:44                                                                 ` Mikulas Patocka
2018-04-26 15:59                                                                   ` Michael S. Tsirkin
2018-04-26 16:07                                                                     ` Mikulas Patocka [this message]
2018-04-26 18:49                                                                       ` Michael S. Tsirkin
2018-04-26 18:54                                                                         ` Mikulas Patocka
2018-04-26 19:14                                                                           ` Michael S. Tsirkin
2018-04-26 19:36                                                                             ` Mikulas Patocka
2018-04-26 19:45                                                                               ` Michael S. Tsirkin
2018-04-26 20:05                                                                                 ` Mikulas Patocka
2018-04-26 18:58                                                                     ` Mikulas Patocka
2018-04-26 19:05                                                                       ` Michael S. Tsirkin
2018-04-26 15:55                                                                 ` Mikulas Patocka
2018-04-25 23:00                                                     ` Mikulas Patocka
2018-04-25 23:08                                                       ` James Bottomley
2018-04-26 14:55                                                         ` Mikulas Patocka
2018-04-26 15:22                                                           ` Mikulas Patocka
2018-04-26 18:58                                                         ` John Stoffel
2018-04-26 21:50                                                           ` Mikulas Patocka
2018-04-26 22:21                                                             ` Michael S. Tsirkin
2018-04-26 22:52                                                               ` Mikulas Patocka
2018-04-27  8:25                                                                 ` Michal Hocko
2018-04-27 10:20                                                                   ` Mikulas Patocka
2018-04-27 23:20                                                               ` Mikulas Patocka
2018-04-30 18:27                                                             ` John Stoffel
2018-04-30 21:07                                                               ` Mikulas Patocka
2018-05-02 13:38                                                                 ` John Stoffel
2018-05-03 17:40                                                                   ` Mikulas Patocka
2018-04-24  0:25                         ` [PATCH] kvmalloc: always use vmalloc if CONFIG_DEBUG_VM Mikulas Patocka
2018-04-24 13:31                           ` Michal Hocko
2018-04-24 15:30                             ` Mikulas Patocka
2018-04-24 16:12                               ` Michal Hocko
2018-04-24 16:29                                 ` Michal Hocko
2018-04-24 16:33                                 ` Mikulas Patocka
2018-05-02  0:36                                   ` Andrew Morton
2018-05-02 13:33                                     ` Mike Snitzer
2018-05-02 13:40                                       ` [dm-devel] " John Stoffel
2018-05-03 17:32                                     ` [PATCH] " Mikulas Patocka
2018-04-18 17:45   ` [PATCH] net: don't use kvzalloc for DMA memory David Miller
2018-04-18 17:55   ` Michael S. Tsirkin
2018-04-18 20:38     ` Eric Dumazet
2018-04-19  4:00       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LRH.2.02.1804261202350.24656@file01.intranet.prod.int.rdu2.redhat.com \
    --to=mpatocka@redhat.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=dm-devel@redhat.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=willy@infradead.org \
    --subject='Re: [dm-devel] [PATCH v5] fault-injection: introduce kvmalloc fallback options' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).