LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v2 0/2] x86/xen: Make idle tasks reliable
@ 2020-03-19  9:56 Miroslav Benes
  2020-03-19  9:56 ` [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable Miroslav Benes
  2020-03-19  9:56 ` [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
  0 siblings, 2 replies; 7+ messages in thread
From: Miroslav Benes @ 2020-03-19  9:56 UTC (permalink / raw)
  To: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa, jpoimboe
  Cc: x86, xen-devel, linux-kernel, live-patching, jslaby,
	andrew.cooper3, Miroslav Benes

The unwinder reports idle tasks' stack on XEN PV as unreliable which
complicates things for at least live patching. The two patches in the
series try to amend that by using similar approach as non-XEN x86 does.

v1->v2:
- call instruction used instead of push+jmp
- initial_stack used directly

There is a thing which makes me slightly uncomfortable. s/jmp/call/
means that, theoretically, the called function could return. GCC then
generates not so nice code and there is
asm_cpu_bringup_and_idle+0x5/0x1000 symbol last on the stack due to
alignment in asm/x86/xen/xen-head.S which could be confusing.
Practically it is all fine, because neither xen_start_kernel(), nor
cpu_bringup_and_idle() return (there is unbounded loop in
cpu_startup_entry() around do_idle()). __noreturn annotation of these
functions did not help.

So I don't think it is really a problem, but one may wonder.

Miroslav Benes (2):
  x86/xen: Make the boot CPU idle task reliable
  x86/xen: Make the secondary CPU idle tasks reliable

 arch/x86/xen/smp_pv.c   |  3 ++-
 arch/x86/xen/xen-head.S | 16 ++++++++++++++--
 2 files changed, 16 insertions(+), 3 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable
  2020-03-19  9:56 [PATCH v2 0/2] x86/xen: Make idle tasks reliable Miroslav Benes
@ 2020-03-19  9:56 ` Miroslav Benes
  2020-03-19 10:01   ` Jan Beulich
  2020-03-19  9:56 ` [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
  1 sibling, 1 reply; 7+ messages in thread
From: Miroslav Benes @ 2020-03-19  9:56 UTC (permalink / raw)
  To: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa, jpoimboe
  Cc: x86, xen-devel, linux-kernel, live-patching, jslaby,
	andrew.cooper3, Miroslav Benes

The unwinder reports the boot CPU idle task's stack on XEN PV as
unreliable, which affects at least live patching. There are two reasons
for this. First, the task does not follow the x86 convention that its
stack starts at the offset right below saved pt_regs. It allows the
unwinder to easily detect the end of the stack and verify it. Second,
startup_xen() function does not store the return address before jumping
to xen_start_kernel() which confuses the unwinder.

Amend both issues by moving the starting point of initial stack in
startup_xen() and storing the return address before the jump, which is
exactly what call instruction does.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 arch/x86/xen/xen-head.S | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index 1d0cee3163e4..edc776af0e0a 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -35,7 +35,11 @@ SYM_CODE_START(startup_xen)
 	rep __ASM_SIZE(stos)
 
 	mov %_ASM_SI, xen_start_info
-	mov $init_thread_union+THREAD_SIZE, %_ASM_SP
+#ifdef CONFIG_X86_64
+	mov initial_stack(%rip), %_ASM_SP
+#else
+	mov pa(initial_stack), %_ASM_SP
+#endif
 
 #ifdef CONFIG_X86_64
 	/* Set up %gs.
@@ -51,7 +55,7 @@ SYM_CODE_START(startup_xen)
 	wrmsr
 #endif
 
-	jmp xen_start_kernel
+	call xen_start_kernel
 SYM_CODE_END(startup_xen)
 	__FINIT
 #endif
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable
  2020-03-19  9:56 [PATCH v2 0/2] x86/xen: Make idle tasks reliable Miroslav Benes
  2020-03-19  9:56 ` [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable Miroslav Benes
@ 2020-03-19  9:56 ` Miroslav Benes
  2020-03-19 10:03   ` Jan Beulich
  1 sibling, 1 reply; 7+ messages in thread
From: Miroslav Benes @ 2020-03-19  9:56 UTC (permalink / raw)
  To: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa, jpoimboe
  Cc: x86, xen-devel, linux-kernel, live-patching, jslaby,
	andrew.cooper3, Miroslav Benes

The unwinder reports the secondary CPU idle tasks' stack on XEN PV as
unreliable, which affects at least live patching.
cpu_initialize_context() sets up the context of the CPU through
VCPUOP_initialise hypercall. After it is woken up, the idle task starts
in cpu_bringup_and_idle() function and its stack starts at the offset
right below pt_regs. The unwinder correctly detects the end of stack
there but it is confused by NULL return address in the last frame.

Introduce a wrapper in assembly, which just calls
cpu_bringup_and_idle(). The return address is thus pushed on the stack
and the wrapper contains the annotation hint for the unwinder regarding
the stack state.

Signed-off-by: Miroslav Benes <mbenes@suse.cz>
---
 arch/x86/xen/smp_pv.c   | 3 ++-
 arch/x86/xen/xen-head.S | 8 ++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/arch/x86/xen/smp_pv.c b/arch/x86/xen/smp_pv.c
index 802ee5bba66c..6b88cdcbef8f 100644
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -53,6 +53,7 @@ static DEFINE_PER_CPU(struct xen_common_irq, xen_irq_work) = { .irq = -1 };
 static DEFINE_PER_CPU(struct xen_common_irq, xen_pmu_irq) = { .irq = -1 };
 
 static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id);
+extern unsigned char asm_cpu_bringup_and_idle[];
 
 static void cpu_bringup(void)
 {
@@ -309,7 +310,7 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle)
 	 * pointing just below where pt_regs would be if it were a normal
 	 * kernel entry.
 	 */
-	ctxt->user_regs.eip = (unsigned long)cpu_bringup_and_idle;
+	ctxt->user_regs.eip = (unsigned long)asm_cpu_bringup_and_idle;
 	ctxt->flags = VGCF_IN_KERNEL;
 	ctxt->user_regs.eflags = 0x1000; /* IOPL_RING1 */
 	ctxt->user_regs.ds = __USER_DS;
diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
index edc776af0e0a..9dc6f9a420a8 100644
--- a/arch/x86/xen/xen-head.S
+++ b/arch/x86/xen/xen-head.S
@@ -58,6 +58,14 @@ SYM_CODE_START(startup_xen)
 	call xen_start_kernel
 SYM_CODE_END(startup_xen)
 	__FINIT
+
+.pushsection .text
+SYM_CODE_START(asm_cpu_bringup_and_idle)
+	UNWIND_HINT_EMPTY
+
+	call cpu_bringup_and_idle
+SYM_CODE_END(asm_cpu_bringup_and_idle)
+.popsection
 #endif
 
 .pushsection .text
-- 
2.25.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable
  2020-03-19  9:56 ` [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable Miroslav Benes
@ 2020-03-19 10:01   ` Jan Beulich
  2020-03-19 10:31     ` Miroslav Benes
  0 siblings, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2020-03-19 10:01 UTC (permalink / raw)
  To: Miroslav Benes
  Cc: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa,
	jpoimboe, andrew.cooper3, x86, linux-kernel, live-patching,
	xen-devel, jslaby

On 19.03.2020 10:56, Miroslav Benes wrote:
> The unwinder reports the boot CPU idle task's stack on XEN PV as
> unreliable, which affects at least live patching. There are two reasons
> for this. First, the task does not follow the x86 convention that its
> stack starts at the offset right below saved pt_regs. It allows the
> unwinder to easily detect the end of the stack and verify it. Second,
> startup_xen() function does not store the return address before jumping
> to xen_start_kernel() which confuses the unwinder.
> 
> Amend both issues by moving the starting point of initial stack in
> startup_xen() and storing the return address before the jump, which is
> exactly what call instruction does.
> 
> Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> ---
>  arch/x86/xen/xen-head.S | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
> index 1d0cee3163e4..edc776af0e0a 100644
> --- a/arch/x86/xen/xen-head.S
> +++ b/arch/x86/xen/xen-head.S
> @@ -35,7 +35,11 @@ SYM_CODE_START(startup_xen)
>  	rep __ASM_SIZE(stos)
>  
>  	mov %_ASM_SI, xen_start_info
> -	mov $init_thread_union+THREAD_SIZE, %_ASM_SP
> +#ifdef CONFIG_X86_64
> +	mov initial_stack(%rip), %_ASM_SP
> +#else
> +	mov pa(initial_stack), %_ASM_SP
> +#endif

If you need to distinguish the two anyway, why not use %rsp and
%esp respectively?

Jan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable
  2020-03-19  9:56 ` [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
@ 2020-03-19 10:03   ` Jan Beulich
  2020-03-19 10:38     ` Miroslav Benes
  0 siblings, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2020-03-19 10:03 UTC (permalink / raw)
  To: Miroslav Benes
  Cc: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa,
	jpoimboe, andrew.cooper3, x86, linux-kernel, live-patching,
	xen-devel, jslaby

On 19.03.2020 10:56, Miroslav Benes wrote:
> --- a/arch/x86/xen/smp_pv.c
> +++ b/arch/x86/xen/smp_pv.c
> @@ -53,6 +53,7 @@ static DEFINE_PER_CPU(struct xen_common_irq, xen_irq_work) = { .irq = -1 };
>  static DEFINE_PER_CPU(struct xen_common_irq, xen_pmu_irq) = { .irq = -1 };
>  
>  static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id);
> +extern unsigned char asm_cpu_bringup_and_idle[];

Imo this would better reflect the actual type, i.e. be a function
decl. If left as an array one, I guess you may want to add const.

Jan

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable
  2020-03-19 10:01   ` Jan Beulich
@ 2020-03-19 10:31     ` Miroslav Benes
  0 siblings, 0 replies; 7+ messages in thread
From: Miroslav Benes @ 2020-03-19 10:31 UTC (permalink / raw)
  To: Jan Beulich
  Cc: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa,
	jpoimboe, andrew.cooper3, x86, linux-kernel, live-patching,
	xen-devel, jslaby

On Thu, 19 Mar 2020, Jan Beulich wrote:

> On 19.03.2020 10:56, Miroslav Benes wrote:
> > The unwinder reports the boot CPU idle task's stack on XEN PV as
> > unreliable, which affects at least live patching. There are two reasons
> > for this. First, the task does not follow the x86 convention that its
> > stack starts at the offset right below saved pt_regs. It allows the
> > unwinder to easily detect the end of the stack and verify it. Second,
> > startup_xen() function does not store the return address before jumping
> > to xen_start_kernel() which confuses the unwinder.
> > 
> > Amend both issues by moving the starting point of initial stack in
> > startup_xen() and storing the return address before the jump, which is
> > exactly what call instruction does.
> > 
> > Signed-off-by: Miroslav Benes <mbenes@suse.cz>
> > ---
> >  arch/x86/xen/xen-head.S | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S
> > index 1d0cee3163e4..edc776af0e0a 100644
> > --- a/arch/x86/xen/xen-head.S
> > +++ b/arch/x86/xen/xen-head.S
> > @@ -35,7 +35,11 @@ SYM_CODE_START(startup_xen)
> >  	rep __ASM_SIZE(stos)
> >  
> >  	mov %_ASM_SI, xen_start_info
> > -	mov $init_thread_union+THREAD_SIZE, %_ASM_SP
> > +#ifdef CONFIG_X86_64
> > +	mov initial_stack(%rip), %_ASM_SP
> > +#else
> > +	mov pa(initial_stack), %_ASM_SP
> > +#endif
> 
> If you need to distinguish the two anyway, why not use %rsp and
> %esp respectively?

I could, I just preferred the unification instead. Will change it if you 
think it would be better.

Miroslav

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable
  2020-03-19 10:03   ` Jan Beulich
@ 2020-03-19 10:38     ` Miroslav Benes
  0 siblings, 0 replies; 7+ messages in thread
From: Miroslav Benes @ 2020-03-19 10:38 UTC (permalink / raw)
  To: Jan Beulich
  Cc: boris.ostrovsky, jgross, sstabellini, tglx, mingo, bp, hpa,
	jpoimboe, andrew.cooper3, x86, linux-kernel, live-patching,
	xen-devel, jslaby

On Thu, 19 Mar 2020, Jan Beulich wrote:

> On 19.03.2020 10:56, Miroslav Benes wrote:
> > --- a/arch/x86/xen/smp_pv.c
> > +++ b/arch/x86/xen/smp_pv.c
> > @@ -53,6 +53,7 @@ static DEFINE_PER_CPU(struct xen_common_irq, xen_irq_work) = { .irq = -1 };
> >  static DEFINE_PER_CPU(struct xen_common_irq, xen_pmu_irq) = { .irq = -1 };
> >  
> >  static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id);
> > +extern unsigned char asm_cpu_bringup_and_idle[];
> 
> Imo this would better reflect the actual type, i.e. be a function
> decl. If left as an array one, I guess you may want to add const.

I sticked to what x86 has for secondary_startup_64. I can make it

void asm_cpu_bringup_and_idle(void);

Miroslav

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-03-19 10:38 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-19  9:56 [PATCH v2 0/2] x86/xen: Make idle tasks reliable Miroslav Benes
2020-03-19  9:56 ` [PATCH v2 1/2] x86/xen: Make the boot CPU idle task reliable Miroslav Benes
2020-03-19 10:01   ` Jan Beulich
2020-03-19 10:31     ` Miroslav Benes
2020-03-19  9:56 ` [PATCH v2 2/2] x86/xen: Make the secondary CPU idle tasks reliable Miroslav Benes
2020-03-19 10:03   ` Jan Beulich
2020-03-19 10:38     ` Miroslav Benes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).