LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Ken Chen" <kenchen@google.com>
To: "Dmitriy Monakhov" <dmonakhov@openvz.org>, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] mm: Move common segments checks to separate function
Date: Thu, 25 Jan 2007 01:16:00 -0800 [thread overview]
Message-ID: <b040c32a0701250116l250338b6r37dc11df10b9d27b@mail.gmail.com> (raw)
In-Reply-To: <1169715856.841146.284660@h3g2000cwc.googlegroups.com>
Dmitriy Monakhov wrote on Jan 24, 11:00 pm
> > Move common segments checks from __generic_file_aio_{read,write}_nolock()
> > to separate helper function generic_segment_checks().WOW my eyes ....
> I'm realy sorry but this patch is litle bit broken. :(
> I've forgot to check generic_segment_checks() return value.
why not remove the for loop all together? like this:
http://groups.google.com/group/linux.kernel/browse_frm/thread/97550ddba48c8c8b/623ddad30b547702?lnk=st&q=&rnum=9#623ddad30b547702
parent reply other threads:[~2007-01-25 9:16 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1169715856.841146.284660@h3g2000cwc.googlegroups.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b040c32a0701250116l250338b6r37dc11df10b9d27b@mail.gmail.com \
--to=kenchen@google.com \
--cc=akpm@osdl.org \
--cc=dmonakhov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [RFC] mm: Move common segments checks to separate function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).