From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30CCC4320A for ; Fri, 6 Aug 2021 11:28:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB648611BF for ; Fri, 6 Aug 2021 11:28:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245498AbhHFL2t (ORCPT ); Fri, 6 Aug 2021 07:28:49 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:46186 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245371AbhHFL2r (ORCPT ); Fri, 6 Aug 2021 07:28:47 -0400 Received: from [10.172.193.212] (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPSA id E19764065E; Fri, 6 Aug 2021 11:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1628249310; bh=TSF6syblnU+wYbj7noZ2K9gDs7lGPeoRUp1P79rvg7w=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=rLiwQ60cBvjSxqmgY/q8PBEs0eDonpUuvxGqCCCANYZehYbTN9nocTlIWu+cqPZWI YTsM2PGBM3zHpkilwfjZO9I8p541EoD0un7uVZ+8p4MKCKQ7bnXRRZhGQLoEemGe8y 9uG2WQ8T3KexgkMcDWKnnYShk+tGaRJ5Fx2gpLISt/gxQc0uJ/iVVjt5yWweVhbYFG MJB9VzYli3lZGZS6wFsz0FOZ5GzLg0ZX5ySAOZPYUtl1a7nuVcpYyPaqwRZVvzhTWl TwILdGJJqxDIlYzxNoTB7MLOM6k4X94hMYwV0BtkXgtBcH6dFEbjn2sM1vnsl2IJbJ XIxZwueXEFquw== Subject: Re: [PATCH][next] brcmfmac: firmware: Fix uninitialized variable ret To: Arend van Spriel , Kalle Valo , Linus Walleij Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , "David S . Miller" , Jakub Kicinski , linux-wireless , brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev , kernel-janitors@vger.kernel.org, linux-kernel References: <20210803150904.80119-1-colin.king@canonical.com> <875ywkc80d.fsf@codeaurora.org> <96709926-30c6-457e-3e80-eb7ad6e9d778@broadcom.com> From: Colin Ian King Message-ID: Date: Fri, 6 Aug 2021 12:28:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <96709926-30c6-457e-3e80-eb7ad6e9d778@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/2021 12:23, Arend van Spriel wrote: > On 05-08-2021 15:53, Kalle Valo wrote: >> Linus Walleij writes: >> >>> On Tue, Aug 3, 2021 at 5:09 PM Colin King >>> wrote: >>> >>>> From: Colin Ian King >>>> >>>> Currently the variable ret is uninitialized and is only set if >>>> the pointer alt_path is non-null. Fix this by ininitializing ret >>>> to zero. >>>> >>>> Addresses-Coverity: ("Uninitialized scalar variable") >>>> Fixes: 5ff013914c62 ("brcmfmac: firmware: Allow per-board firmware >>>> binaries") >>>> Signed-off-by: Colin Ian King >>> >>> Nice catch! >>> Reviewed-by: Linus Walleij >> >> I assume this will be fixed by Linus' patch "brcmfmac: firmware: Fix >> firmware loading" and I should drop Colin's patch, correct? > > That would be my assumption as well, but not sure when he will submit > another revision of it. You probably know what to do ;-) I'd prefer my patch to be dropped in preference to Linus' fix. > > Regards, > Arend