LKML Archive on
help / color / mirror / Atom feed
From: Zhang Qiao <>
To: Tejun Heo <>
Cc: <>, <>,
	<>, <>,
	<>, <>,
	<>, <>, <>,
Subject: Re: [PATCH v2] kernel/sched: Fix sched_fork() access an invalid sched_task_group
Date: Tue, 14 Sep 2021 16:20:02 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

在 2021/9/14 2:01, Tejun Heo 写道:
> Hello,
> On Sat, Sep 11, 2021 at 03:50:54PM +0800, Zhang Qiao wrote:
>> Between cgroup_can_fork() and cgroup_post_fork(), the cgroup
>> membership is fixed and thus sched_task_group can't change. So
>> call sched_fork() after cgroup_can_fork() and update the child's
>> sched_task_group before it is used.
> The part being fixed looks correct to me but it's difficult to for me to
> assess whether the whole relocation of the sched_fork() hook doesn't change

Indeed is this, although I checked and tested it many times.

> anything else. Besides, even if we decide to relocate the sched_fork hook, I
> think it'd be better to separate the two changes - one is a relatively safe
> bug fix, the other is a code reorganization with possibly subtle side
> effects. So, I think it'd be better to produce a patch which just fixes the
> bug even if that ends up introducing another function in the flow.

Perhaps we can fix this bug at sched_post_fork(), which is executed between cgroup_can_fork()
and cgroup_post_fork(). Relocate the fectching of task_group and access it at sched_post_fork().


> Thanks.

  reply	other threads:[~2021-09-14  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-11  7:50 Zhang Qiao
2021-09-13 18:01 ` Tejun Heo
2021-09-14  8:20   ` Zhang Qiao [this message]
2021-09-14 16:23     ` Tejun Heo
2021-09-15  3:10       ` Zhang Qiao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] kernel/sched: Fix sched_fork() access an invalid sched_task_group' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).