LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: m.szyprowski@samsung.com, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-debug: Check scatterlist segments
Date: Tue, 8 May 2018 11:14:32 +0100	[thread overview]
Message-ID: <b49180f4-3e1b-d1f3-c6c3-98fbe1e66e4b@arm.com> (raw)
In-Reply-To: <20180425055856.GA10738@lst.de>

On 25/04/18 06:58, Christoph Hellwig wrote:
> This looks interesting.  I suspect it is going to blow up in
> quite a few places, so maybe at least for now it might make sense
> to have a separate config option?

True, it's nice to verify this for 'traditional' dma_map_sg() usage, but 
places where it's just used as an intermediate shorthand for "prepare 
all these pages for arbitrary future DMA" are liable to be noisy with 
false-positives for not respecting the default values when they arguably 
don't matter. I'll respin this as an additional config under 
DMA_API_DEBUG, and then we can debate "default y" or not.

Robin.

> On Tue, Apr 24, 2018 at 05:12:19PM +0100, Robin Murphy wrote:
>> Drivers/subsystems creating scatterlists for DMA should be taking care
>> to respect the scatter-gather limitations of the appropriate device, as
>> described by dma_parms. A DMA API implementation cannot feasibly split
>> a scatterlist into *more* entries than originally passed, so it is not
>> well defined what they should do when given a segment larger than the
>> limit they are also required to respect.
>>
>> Conversely, devices which are less limited than the rather conservative
>> defaults, or indeed have no limitations at all (e.g. GPUs with their own
>> internal MMU), should be encouraged to set appropriate dma_parms, as
>> they may get more efficient DMA mapping performance out of it.
>>
>> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
>> ---
>>   lib/dma-debug.c | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>>
>> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
>> index 7f5cdc1e6b29..9f158941004d 100644
>> --- a/lib/dma-debug.c
>> +++ b/lib/dma-debug.c
>> @@ -1293,6 +1293,30 @@ static void check_sync(struct device *dev,
>>   	put_hash_bucket(bucket, &flags);
>>   }
>>   
>> +static void check_sg_segment(struct device *dev, struct scatterlist *sg)
>> +{
>> +	unsigned int max_seg = dma_get_max_seg_size(dev);
>> +	dma_addr_t start, end, boundary = dma_get_seg_boundary(dev);
>> +
>> +	/*
>> +	 * Either the driver forgot to set dma_parms appropriately, or
>> +	 * whoever generated the list forgot to check them.
>> +	 */
>> +	if (sg->length > max_seg)
>> +		err_printk(dev, NULL, "DMA-API: mapping sg segment longer than device claims to support [len=%u] [max=%u]\n",
>> +			   sg->length, max_seg);
>> +	/*
>> +	 * In some cases this could potentially be the DMA API
>> +	 * implementation's fault, but it would usually imply that
>> +	 * the scatterlist was built inappropriately to begin with.
>> +	 */
>> +	start = sg_dma_address(sg);
>> +	end = start + sg_dma_len(sg) - 1;
>> +	if ((start ^ end) & ~boundary)
>> +		err_printk(dev, NULL, "DMA-API: mapping sg segment across boundary [start=0x%016llx] [end=0x%016llx] [boundary=0x%016llx]\n",
>> +			   start, end, boundary);
>> +}
>> +
>>   void debug_dma_map_page(struct device *dev, struct page *page, size_t offset,
>>   			size_t size, int direction, dma_addr_t dma_addr,
>>   			bool map_single)
>> @@ -1423,6 +1447,8 @@ void debug_dma_map_sg(struct device *dev, struct scatterlist *sg,
>>   			check_for_illegal_area(dev, sg_virt(s), sg_dma_len(s));
>>   		}
>>   
>> +		check_sg_segment(dev, s);
>> +
>>   		add_dma_entry(entry);
>>   	}
>>   }
>> -- 
>> 2.17.0.dirty
> ---end quoted text---
> 

      reply	other threads:[~2018-05-08 10:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 16:12 Robin Murphy
2018-04-25  4:52 ` kbuild test robot
2018-04-25  5:58 ` Christoph Hellwig
2018-05-08 10:14   ` Robin Murphy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b49180f4-3e1b-d1f3-c6c3-98fbe1e66e4b@arm.com \
    --to=robin.murphy@arm.com \
    --cc=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --subject='Re: [PATCH] dma-debug: Check scatterlist segments' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).