LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Daniel Bristot de Oliveira <bristot@kernel.org>,
	linux-kernel@vger.kernel.org
Cc: Matthew Wilcox <willy@infradead.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH] trace/osnoise: Rename main variable to tracer_main
Date: Tue, 3 Aug 2021 07:31:10 -0700	[thread overview]
Message-ID: <b4cbe5a3-c76f-4fc0-4cf6-1d6ff729b971@infradead.org> (raw)
In-Reply-To: <fc62f7deb2258f6068d77c3e734633e3c3511464.1627977494.git.bristot@kernel.org>

On 8/3/21 1:28 AM, Daniel Bristot de Oliveira wrote:
> The *main variable in start_kthread() is causing warnings in some
> compilers/analyzers. Although it is not necessarily a problem, it is
> not a problem changing the variable name too.
> 
> Rename the *main variable to *tracer_main.
> 
> No functional change.
> 
> Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Daniel Bristot de Oliveira <bristot@kernel.org>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>   kernel/trace/trace_osnoise.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c
> index 0b11db9595b6..eda10d39da47 100644
> --- a/kernel/trace/trace_osnoise.c
> +++ b/kernel/trace/trace_osnoise.c
> @@ -1576,20 +1576,20 @@ static void stop_per_cpu_kthreads(void)
>   static int start_kthread(unsigned int cpu)
>   {
>   	struct task_struct *kthread;
> -	void *main = osnoise_main;
> +	void *tracer_main = osnoise_main;
>   	char comm[24];
>   
>   #ifdef CONFIG_TIMERLAT_TRACER
>   	if (osnoise_data.timerlat_tracer) {
>   		snprintf(comm, 24, "timerlat/%d", cpu);
> -		main = timerlat_main;
> +		tracer_main = timerlat_main;
>   	} else {
>   		snprintf(comm, 24, "osnoise/%d", cpu);
>   	}
>   #else
>   	snprintf(comm, 24, "osnoise/%d", cpu);
>   #endif
> -	kthread = kthread_create_on_cpu(main, NULL, cpu, comm);
> +	kthread = kthread_create_on_cpu(tracer_main, NULL, cpu, comm);
>   
>   	if (IS_ERR(kthread)) {
>   		pr_err(BANNER "could not start sampling thread\n");
> 


-- 
~Randy


      reply	other threads:[~2021-08-03 14:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-03  8:28 Daniel Bristot de Oliveira
2021-08-03 14:31 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4cbe5a3-c76f-4fc0-4cf6-1d6ff729b971@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=bristot@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH] trace/osnoise: Rename main variable to tracer_main' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).