LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre Morel <pmorel@linux.vnet.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>,
	Dong Jia Shi <bjsdjshi@linux.ibm.com>,
	Halil Pasic <pasic@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio-ccw: process ssch with interrupts disabled
Date: Thu, 19 Apr 2018 16:14:25 +0200	[thread overview]
Message-ID: <b52e3aac-208c-8d55-cc77-2534a375fda5@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180413140509.9042-1-cohuck@redhat.com>

On 13/04/2018 16:05, Cornelia Huck wrote:
> When we call ssch, an interrupt might already be pending once we
> return from the START SUBCHANNEL instruction. Therefore we need to
> make sure interrupts are disabled until after we're done with our
> processing.
>
> Note that the subchannel lock is the same as the ccwdevice lock that
> is mentioned in the documentation for ccw_device_start() and friends.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
>   drivers/s390/cio/vfio_ccw_fsm.c | 19 ++++++++++++-------
>   1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/s390/cio/vfio_ccw_fsm.c b/drivers/s390/cio/vfio_ccw_fsm.c
> index ff6963ad6e39..3c800642134e 100644
> --- a/drivers/s390/cio/vfio_ccw_fsm.c
> +++ b/drivers/s390/cio/vfio_ccw_fsm.c
> @@ -20,12 +20,12 @@ static int fsm_io_helper(struct vfio_ccw_private *private)
>   	int ccode;
>   	__u8 lpm;
>   	unsigned long flags;
> +	int ret;
>
>   	sch = private->sch;
>
>   	spin_lock_irqsave(sch->lock, flags);
>   	private->state = VFIO_CCW_STATE_BUSY;
> -	spin_unlock_irqrestore(sch->lock, flags);
>
>   	orb = cp_get_orb(&private->cp, (u32)(addr_t)sch, sch->lpm);
>
> @@ -38,10 +38,12 @@ static int fsm_io_helper(struct vfio_ccw_private *private)
>   		 * Initialize device status information
>   		 */
>   		sch->schib.scsw.cmd.actl |= SCSW_ACTL_START_PEND;
> -		return 0;
> +		ret = 0;
> +		break;
>   	case 1:		/* Status pending */
>   	case 2:		/* Busy */
> -		return -EBUSY;
> +		ret = -EBUSY;
> +		break;
>   	case 3:		/* Device/path not operational */
>   	{
>   		lpm = orb->cmd.lpm;
> @@ -51,13 +53,16 @@ static int fsm_io_helper(struct vfio_ccw_private *private)
>   			sch->lpm = 0;
>
>   		if (cio_update_schib(sch))
> -			return -ENODEV;
> -
> -		return sch->lpm ? -EACCES : -ENODEV;
> +			ret = -ENODEV;
> +		else
> +			ret = sch->lpm ? -EACCES : -ENODEV;
> +		break;
>   	}
>   	default:
> -		return ccode;
> +		ret = ccode;
>   	}
> +	spin_unlock_irqrestore(sch->lock, flags);
> +	return ret;
>   }
>
>   static void fsm_notoper(struct vfio_ccw_private *private,


I have been working on a patch to solve this problem between others, I 
provide it soon.
It is much more intrusive, reworking interrupts and state machine.
So may be you do not like it.


If we stay on this patch, even this is quite a long spinlock around ssch 
and stsch,
and we need it in the current implementation.

Acked-by: Pierre Morel<pmorel@linux.vnet.ibm.com>



-- 
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany

  parent reply	other threads:[~2018-04-19 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 14:05 Cornelia Huck
     [not found] ` <20180416021312.GO12194@bjsdjshi@linux.vnet.ibm.com>
2018-04-16  9:35   ` Cornelia Huck
     [not found] ` <20180418082931.GO5428@bjsdjshi@linux.vnet.ibm.com>
2018-04-19  9:16   ` Cornelia Huck
2018-04-19 12:01 ` Halil Pasic
2018-04-19 14:14 ` Pierre Morel [this message]
2018-04-19 15:22   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b52e3aac-208c-8d55-cc77-2534a375fda5@linux.vnet.ibm.com \
    --to=pmorel@linux.vnet.ibm.com \
    --cc=bjsdjshi@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    --subject='Re: [PATCH] vfio-ccw: process ssch with interrupts disabled' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).