LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] clk: armada-xp: Remove unused variables
@ 2019-05-21  8:58 Philippe Mazenauer
  2019-05-21 21:31 ` Chris Packham
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mazenauer @ 2019-05-21  8:58 UTC (permalink / raw)
  Cc: Philippe Mazenauer, Michael Turquette, Stephen Boyd,
	Gregory CLEMENT, Yangtao Li, open list:COMMON CLK FRAMEWORK,
	open list

Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
declared static and initialized, but are not used in the file.

../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
 static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
                                         ^~~~~~~~~~~~~~~~~~~~~~
../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
 static const struct coreclk_soc_desc mv98dx3236_coreclks = {
                                      ^~~~~~~~~~~~~~~~~~~

Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
---
 drivers/clk/mvebu/armada-xp.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
index fa1568279c23..2ae24a5debd0 100644
--- a/drivers/clk/mvebu/armada-xp.c
+++ b/drivers/clk/mvebu/armada-xp.c
@@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
 	.num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
 };
 
-static const struct coreclk_soc_desc mv98dx3236_coreclks = {
-	.get_tclk_freq = mv98dx3236_get_tclk_freq,
-	.get_cpu_freq = mv98dx3236_get_cpu_freq,
-};
-
 /*
  * Clock Gating Control
  */
@@ -210,15 +205,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
 	{ }
 };
 
-static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
-	{ "ge1", NULL, 3, 0 },
-	{ "ge0", NULL, 4, 0 },
-	{ "pex00", NULL, 5, 0 },
-	{ "sdio", NULL, 17, 0 },
-	{ "xor0", NULL, 22, 0 },
-	{ }
-};
-
 static void __init axp_clk_init(struct device_node *np)
 {
 	struct device_node *cgnp =
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: armada-xp: Remove unused variables
  2019-05-21  8:58 [PATCH] clk: armada-xp: Remove unused variables Philippe Mazenauer
@ 2019-05-21 21:31 ` Chris Packham
  2019-06-06 17:48 ` Stephen Boyd
  2019-06-06 18:07 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Chris Packham @ 2019-05-21 21:31 UTC (permalink / raw)
  To: Philippe Mazenauer, Michael Turquette, Stephen Boyd, Gregory CLEMENT
  Cc: Yangtao Li, linux-clk, linux-kernel, stable

Hi Philippe,

On 21/05/19 8:58 PM, Philippe Mazenauer wrote:
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
> 
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
>   static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
>                                           ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
>   static const struct coreclk_soc_desc mv98dx3236_coreclks = {
>                                        ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>

The usage of these was moved to a separate file in a later commit and 
the original code wasn't fully cleaned up.

Fixes: 337072604224 ("clk: mvebu: Expand mv98dx3236-core-clock support")
Cc: stable@vger.kernel.org
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Thanks

> ---
>   drivers/clk/mvebu/armada-xp.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
>   	.num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
>   };
>   
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> -	.get_tclk_freq = mv98dx3236_get_tclk_freq,
> -	.get_cpu_freq = mv98dx3236_get_cpu_freq,
> -};
> -
>   /*
>    * Clock Gating Control
>    */
> @@ -210,15 +205,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
>   	{ }
>   };
>   
> -static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> -	{ "ge1", NULL, 3, 0 },
> -	{ "ge0", NULL, 4, 0 },
> -	{ "pex00", NULL, 5, 0 },
> -	{ "sdio", NULL, 17, 0 },
> -	{ "xor0", NULL, 22, 0 },
> -	{ }
> -};
> -
>   static void __init axp_clk_init(struct device_node *np)
>   {
>   	struct device_node *cgnp =
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: armada-xp: Remove unused variables
  2019-05-21  8:58 [PATCH] clk: armada-xp: Remove unused variables Philippe Mazenauer
  2019-05-21 21:31 ` Chris Packham
@ 2019-06-06 17:48 ` Stephen Boyd
  2019-06-06 18:07 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-06-06 17:48 UTC (permalink / raw)
  To: Philippe Mazenauer
  Cc: Philippe Mazenauer, Michael Turquette, Gregory CLEMENT,
	Yangtao Li, open list:COMMON CLK FRAMEWORK, open list

Quoting Philippe Mazenauer (2019-05-21 01:58:41)
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
> 
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
>  static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
>                                          ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
>  static const struct coreclk_soc_desc mv98dx3236_coreclks = {
>                                       ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> ---

The patch is base64 encoded.... Sigh outlook!

>  drivers/clk/mvebu/armada-xp.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
>         .num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
>  };
>  
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> -       .get_tclk_freq = mv98dx3236_get_tclk_freq,
> -       .get_cpu_freq = mv98dx3236_get_cpu_freq,
> -};
> -
>  /*
>   * Clock Gating Control
>   */
> @@ -210,15 +205,6 @@ static const struct clk_gating_soc_desc axp_gating_desc[] __initconst = {
>         { }
>  };
>  
> -static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
> -       { "ge1", NULL, 3, 0 },
> -       { "ge0", NULL, 4, 0 },
> -       { "pex00", NULL, 5, 0 },
> -       { "sdio", NULL, 17, 0 },
> -       { "xor0", NULL, 22, 0 },
> -       { }
> -};
> -
>  static void __init axp_clk_init(struct device_node *np)
>  {
>         struct device_node *cgnp =

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] clk: armada-xp: Remove unused variables
  2019-05-21  8:58 [PATCH] clk: armada-xp: Remove unused variables Philippe Mazenauer
  2019-05-21 21:31 ` Chris Packham
  2019-06-06 17:48 ` Stephen Boyd
@ 2019-06-06 18:07 ` Stephen Boyd
  2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2019-06-06 18:07 UTC (permalink / raw)
  To: Philippe Mazenauer
  Cc: Philippe Mazenauer, Michael Turquette, Gregory CLEMENT,
	Yangtao Li, open list:COMMON CLK FRAMEWORK, open list

Quoting Philippe Mazenauer (2019-05-21 01:58:41)
> Variables 'mv98dx3236_gating_desc' and 'mv98dx3236_coreclks' are
> declared static and initialized, but are not used in the file.
> 
> ../drivers/clk/mvebu/armada-xp.c:213:41: warning: ‘mv98dx3236_gating_desc’ defined but not used [-Wunused-const-variable=]
>  static const struct clk_gating_soc_desc mv98dx3236_gating_desc[] __initconst = {
>                                          ^~~~~~~~~~~~~~~~~~~~~~
> ../drivers/clk/mvebu/armada-xp.c:171:38: warning: ‘mv98dx3236_coreclks’ defined but not used [-Wunused-const-variable=]
>  static const struct coreclk_soc_desc mv98dx3236_coreclks = {
>                                       ^~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> ---
>  drivers/clk/mvebu/armada-xp.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/clk/mvebu/armada-xp.c b/drivers/clk/mvebu/armada-xp.c
> index fa1568279c23..2ae24a5debd0 100644
> --- a/drivers/clk/mvebu/armada-xp.c
> +++ b/drivers/clk/mvebu/armada-xp.c
> @@ -168,11 +168,6 @@ static const struct coreclk_soc_desc axp_coreclks = {
>         .num_ratios = ARRAY_SIZE(axp_coreclk_ratios),
>  };
>  
> -static const struct coreclk_soc_desc mv98dx3236_coreclks = {
> -       .get_tclk_freq = mv98dx3236_get_tclk_freq,
> -       .get_cpu_freq = mv98dx3236_get_cpu_freq,

These functions are unused after applying this patch. Can you resend by
test compiling the code?


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-06-06 18:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-21  8:58 [PATCH] clk: armada-xp: Remove unused variables Philippe Mazenauer
2019-05-21 21:31 ` Chris Packham
2019-06-06 17:48 ` Stephen Boyd
2019-06-06 18:07 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).