LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
To: "Hiroshi Shimamoto" <h-shimamoto@ct.jp.nec.com>
Cc: "Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@elte.hu>,
	linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org,
	hpj@urpla.net, stable <stable@kernel.org>
Subject: Re: [PATCH] sched: fix race in schedule
Date: Fri, 14 Mar 2008 23:47:05 +0100	[thread overview]
Message-ID: <b647ffbd0803141547s55fa37a1j5af4e50388d3117f@mail.gmail.com> (raw)
In-Reply-To: <47DABCE0.2070505@ct.jp.nec.com>

On 14/03/2008, Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
>
> [ ... ]
>
>  >> But maybe there is something esle that would be exposed by the
>  >> 'rq->curr = rq->idle' manipulation... I can't provide examples right
>  >> now though (I need to think on it).
>  >
>  > I share your concerns, I don't really like it either. Just spewing out
>  > ideas here - bad ideas it seems :-/
>  >
>  > Ingo also suggested moving the balance calls right before
>  > deactivate_task(), but that gives a whole other set of head-aches.
>  >
>
>
> Well, what will we do about this issue?
>  I see you're thinking to fix inconsistency in scheduler, right?
>  I agree about it.
>
>  However, I don't think it's good to remain this issue long time in
>  the -stable kernel.
>
>  Could you please let me know what I can do?

IMHO, the safest solution for the time being (and esp. for -stable)
would be to proceed with Hiroshi's patch. It looks safe and it does
fix a real problem.


>
> Hiroshi Shimamoto
>

-- 
Best regards,
Dmitry Adamushko

  reply	other threads:[~2008-03-14 22:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 18:01 Hiroshi Shimamoto
2008-03-10 18:36 ` Peter Zijlstra
2008-03-10 20:01   ` Hiroshi Shimamoto
2008-03-10 20:34     ` Peter Zijlstra
2008-03-10 20:54       ` Hiroshi Shimamoto
2008-03-10 21:01         ` Peter Zijlstra
2008-03-10 21:07           ` Hiroshi Shimamoto
2008-03-11  2:12       ` Hiroshi Shimamoto
2008-03-11  8:40         ` Peter Zijlstra
2008-03-11 17:10           ` Hiroshi Shimamoto
2008-03-11 23:38             ` Dmitry Adamushko
2008-03-12 13:27               ` Peter Zijlstra
2008-03-12 14:48                 ` Dmitry Adamushko
2008-03-12 14:57                   ` Peter Zijlstra
2008-03-14 17:58                     ` Hiroshi Shimamoto
2008-03-14 22:47                       ` Dmitry Adamushko [this message]
2008-03-14 22:57                         ` Peter Zijlstra
2008-03-20  5:44 ` Sripathi Kodi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b647ffbd0803141547s55fa37a1j5af4e50388d3117f@mail.gmail.com \
    --to=dmitry.adamushko@gmail.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=hpj@urpla.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=stable@kernel.org \
    --subject='Re: [PATCH] sched: fix race in schedule' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).