From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161113AbXCNKsc (ORCPT ); Wed, 14 Mar 2007 06:48:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161095AbXCNKsc (ORCPT ); Wed, 14 Mar 2007 06:48:32 -0400 Received: from wx-out-0506.google.com ([66.249.82.224]:22390 "EHLO wx-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161113AbXCNKsb (ORCPT ); Wed, 14 Mar 2007 06:48:31 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JDxPLt2acdnP3mCyGRVwVLarBDtXg+U4C943KdlAwlCijevezFbkJQL8JhQGmg8FDJ+DPm5bSKK93Aa+dBfxouvKD8qkFR3vOKMJ/OAWxxChN9qJXKvyCx0peuBpdiH0NwEoA0neO3ioigN+Cpzkb3bd8YHFycxUKvidBHF9fn4= Message-ID: Date: Wed, 14 Mar 2007 12:48:30 +0200 From: "Alexey Dobriyan" To: "Ingo Molnar" Subject: Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support Cc: "Eric W. Biederman" , linux-kernel@vger.kernel.org, "Andrew Morton" , "Adrian Bunk" , "Alexander Viro" In-Reply-To: <20070314103832.GA16104@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <11689657073389-git-send-email-ebiederm@xmission.com> <20070314103832.GA16104@elte.hu> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 3/14/07, Ingo Molnar wrote: > #define PROCNAME_PML "sys/kernel/preempt_max_latency" > > static __init int latency_fs_init(void) > { > struct proc_dir_entry *entry; > > if (!(entry = create_proc_entry(PROCNAME_PML, 0644, NULL))) > printk("latency_fs_init(): can't create %s\n", > PROCNAME_PML); > > with your change that broke because beyond /proc/sys/ there are no real > proc entries anymore, there's no de->subdir directory for > xlate_proc_name() to find. While the latency tracer isnt upstream, this > change in semantics does not seem to be intended (the changelog is > certainly silent about it). Use register_sysctl_table() for sysctls.