From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbeEQLMn (ORCPT ); Thu, 17 May 2018 07:12:43 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:40350 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751233AbeEQLMm (ORCPT ); Thu, 17 May 2018 07:12:42 -0400 Subject: Re: [PATCH v2] f2fs: Fix deadlock in shutdown ioctl To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1526544211-26218-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Thu, 17 May 2018 19:12:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1526544211-26218-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/5/17 16:03, Sahitya Tummala wrote: > f2fs_ioc_shutdown() ioctl gets stuck in the below path > when issued with F2FS_GOING_DOWN_FULLSYNC option. > > __switch_to+0x90/0xc4 > percpu_down_write+0x8c/0xc0 > freeze_super+0xec/0x1e4 > freeze_bdev+0xc4/0xcc > f2fs_ioctl+0xc0c/0x1ce0 > f2fs_compat_ioctl+0x98/0x1f0 > > Signed-off-by: Sahitya Tummala > --- > v2: > remove lock coverage for only F2FS_GOING_DOWN_FULLSYNC case as suggested by Chao. > > fs/f2fs/file.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c > index 6b94f19..5a132c9 100644 > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -1857,6 +1857,7 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) How about: if (in != F2FS_GOING_DOWN_FULLSYNC) mnt_want_write_file(); switch() { handle command; } if (in != F2FS_GOING_DOWN_FULLSYNC) mnt_drop_write_file(); Thanks, > > switch (in) { > case F2FS_GOING_DOWN_FULLSYNC: > + mnt_drop_write_file(filp); > sb = freeze_bdev(sb->s_bdev); > if (IS_ERR(sb)) { > ret = PTR_ERR(sb); > @@ -1894,7 +1895,8 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) > > f2fs_update_time(sbi, REQ_TIME); > out: > - mnt_drop_write_file(filp); > + if (in != F2FS_GOING_DOWN_FULLSYNC) > + mnt_drop_write_file(filp); > return ret; > } > >