LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Rakib Mullick" <rakib.mullick@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH -mm] ftrace : Fix section mismatch warning.
Date: Fri, 24 Oct 2008 17:09:49 +0600	[thread overview]
Message-ID: <b9df5fa10810240409u311bb337x1ff9815431088685@mail.gmail.com> (raw)
In-Reply-To: <20081022070312.GA24749@elte.hu>

On 10/22/08, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
>>
>> * Rakib Mullick <rakib.mullick@gmail.com> wrote:
>>
>> > WARNING: arch/x86/kernel/built-in.o(.text+0x11b41): Section mismatch
>> > in reference from the variable ftrace_test_p6nop to the function
>> > .init.text:ftrace_dyn_arch_init()
>> > The function ftrace_test_p6nop() references
>> > the function __init ftrace_dyn_arch_init().
>> > This is often because ftrace_test_p6nop lacks a __init
>> > annotation or the annotation of ftrace_dyn_arch_init is wrong.
>> >
>> > WARNING: arch/x86/kernel/built-in.o(.text+0x11b4b): Section mismatch
>> > in reference from the variable ftrace_test_nop5 to the function
>> > .init.text:ftrace_dyn_arch_init()
>> > The function ftrace_test_nop5() references
>> > the function __init ftrace_dyn_arch_init().
>> > This is often because ftrace_test_nop5 lacks a __init
>> > annotation or the annotation of ftrace_dyn_arch_init is wrong.
>> >
>> > This patch fixes the above warnings. Introduced by
>> > 'linux-next.patch'(2.6.27-rc5-mm1-broken-out).
>> > Thanks.
>> >
>> > Signed-off-by: Md.Rakib H. Mullick(rakib.mullick@gmail.com)
>>
>> applied to tip/tracing/urgent, thanks!
>
> actually, this patch is wrong: the problem highlighted in that warning
> is that ftrace_test_p6nop is non-__init while ftrace_dyn_arch_init() is
> __init. So the proper solution is to mark ftrace_test_p6nop init as
> well. (it's an assembly label so thus slightly more complex than usual,
> but doable.)

Does the following solves the problem?
Thanks.

--- linux-2.6-orig/arch/x86/kernel/ftrace.c	2008-10-24 16:35:48.000000000 +0600
+++ linux-2.6/arch/x86/kernel/ftrace.c	2008-10-24 16:40:09.000000000 +0600
@@ -129,7 +129,7 @@ int __init ftrace_dyn_arch_init(void *da
 	asm volatile (
 		"jmp ftrace_test_jmp\n"
 		/* This code needs to stay around */
-		".section .text, \"ax\"\n"
+		".section .text.init, \"ax\"\n"
 		"ftrace_test_jmp:"
 		"jmp ftrace_test_p6nop\n"
 		"nop\n"

>
> 	Ingo
>

  reply	other threads:[~2008-10-24 11:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-13  5:50 Rakib Mullick
2008-10-20 16:27 ` Ingo Molnar
2008-10-22  7:03   ` Ingo Molnar
2008-10-24 11:09     ` Rakib Mullick [this message]
2008-10-24 11:50       ` Ingo Molnar
2008-10-24 12:19         ` Steven Rostedt
2008-10-24 12:22           ` Steven Rostedt
2008-10-24 13:12         ` [PATCH] ftrace: use a real variable for ftrace_nop in x86 Steven Rostedt
2008-10-24 13:17           ` Steven Rostedt
2008-10-27 15:52             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b9df5fa10810240409u311bb337x1ff9815431088685@mail.gmail.com \
    --to=rakib.mullick@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --subject='Re: [PATCH -mm] ftrace : Fix section mismatch warning.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).