LKML Archive on
help / color / mirror / Atom feed
From: "Rakib Mullick" <>
Cc: "Ingo Molnar" <>,
	"Andrew Morton" <>,,
Subject: [PATCH 1/2] x86: Fixing improper annotation.
Date: Tue, 11 Nov 2008 10:15:15 +0600	[thread overview]
Message-ID: <> (raw)

The macro __init used in function 'init_thread_xstate' is not
appropriate. It should be __cpuinit , because it's been called from
__cpuinit functions several times ( I myself found twice, once from
'cpu_init' and other is from 'fpu_init'). Thus produces the following

WARNING: arch/x86/kernel/built-in.o(.cpuinit.text+0x2237): Section
mismatch in reference from the function cpu_init() to the function
The function __cpuinit cpu_init() references
a function __init init_thread_xstate().
If init_thread_xstate is only used by cpu_init then
annotate init_thread_xstate with a matching annotation.

This patch fixes the above warning. If anything else please notice.

Signed-off-by: Rakib Mullick <>

--- linux-2.6-orig/arch/x86/kernel/i387.c	2008-11-10 13:28:17.000000000 +0600
+++ linux-2.6/arch/x86/kernel/i387.c	2008-11-10 23:35:09.000000000 +0600
@@ -58,7 +58,7 @@ void __cpuinit mxcsr_feature_mask_init(v

-void __init init_thread_xstate(void)
+void __cpuinit init_thread_xstate(void)
 	if (!HAVE_HWFP) {
 		xstate_size = sizeof(struct i387_soft_struct);

             reply	other threads:[~2008-11-11  4:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11  4:15 Rakib Mullick [this message]
2008-11-11  8:06 Re:[PATCH 1/2] x86: Fixing improper annotation Rufus & Azrael
2008-11-11 10:36 ` [PATCH " Ingo Molnar
2008-11-11 10:48   ` Rufus & Azrael
2008-11-11 10:41     ` Ingo Molnar
2008-11-12  0:35       ` Rakib Mullick
2008-11-14  3:27         ` Rakib Mullick
2008-11-18 21:39           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).