LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* 撤回: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()
@ 2021-07-31  2:16 wangliang (C)
  0 siblings, 0 replies; 7+ messages in thread
From: wangliang (C) @ 2021-07-31  2:16 UTC (permalink / raw)
  To: Luis Chamberlain
  Cc: palmerdabbelt, linux-kernel, gregkh, linux, linux-arm-kernel,
	stable, Wangle (RTOS FAE), Chenxin (RTOS),
	Nixiaoming, Wangkefeng (OS Kernel Lab)

wangliang (C) 将撤回邮件“[PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()”。

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed()
@ 2021-07-30  7:43 Liang Wang
  2021-07-30 19:36 ` Luis Chamberlain
  0 siblings, 1 reply; 7+ messages in thread
From: Liang Wang @ 2021-07-30  7:43 UTC (permalink / raw)
  To: palmerdabbelt, mcgrof, linux-kernel, gregkh, linux, linux-arm-kernel
  Cc: stable, wangliang101, wangle6, kepler.chenxin, nixiaoming,
	wangkefeng.wang

The physical address may exceed 32 bits on ARM(when ARM_LPAE enabled),
use PFN_PHYS() in devmem_is_allowed(), or the physical address may
overflow and be truncated.

This bug was initially introduced from v2.6.37, and the function was moved
to lib when v5.11.

Fixes: 087aaffcdf9c ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Fixes: 527701eda5f1 ("lib: Add a generic version of devmem_is_allowed()")
Cc: stable@vger.kernel.org # v2.6.37
Signed-off-by: Liang Wang <wangliang101@huawei.com>
---
v2: update subject and changelog
 lib/devmem_is_allowed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/devmem_is_allowed.c b/lib/devmem_is_allowed.c
index c0d67c541849..60be9e24bd57 100644
--- a/lib/devmem_is_allowed.c
+++ b/lib/devmem_is_allowed.c
@@ -19,7 +19,7 @@
  */
 int devmem_is_allowed(unsigned long pfn)
 {
-	if (iomem_is_exclusive(pfn << PAGE_SHIFT))
+	if (iomem_is_exclusive(PFN_PHYS(pfn)))
 		return 0;
 	if (!page_is_ram(pfn))
 		return 1;
-- 
2.32.0


^ permalink raw reply	[flat|nested] 7+ messages in thread
[parent not found: <20210730064915.56249-1-wangliang101@huawei.com>]

end of thread, other threads:[~2021-08-04  5:03 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31  2:16 撤回: [PATCH v2] lib: Use PFN_PHYS() in devmem_is_allowed() wangliang (C)
  -- strict thread matches above, loose matches on Subject: below --
2021-07-30  7:43 Liang Wang
2021-07-30 19:36 ` Luis Chamberlain
2021-07-31  2:04   ` 答复: " wangliang (C)
     [not found] <20210730064915.56249-1-wangliang101@huawei.com>
2021-07-30  7:04 ` Kefeng Wang
2021-08-04  0:20   ` Palmer Dabbelt
2021-08-04  5:03     ` Kefeng Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).