From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800EFC4320A for ; Fri, 30 Jul 2021 13:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 55C1760E76 for ; Fri, 30 Jul 2021 13:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238978AbhG3Nu7 (ORCPT ); Fri, 30 Jul 2021 09:50:59 -0400 Received: from mga17.intel.com ([192.55.52.151]:16708 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231137AbhG3Nu6 (ORCPT ); Fri, 30 Jul 2021 09:50:58 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10060"; a="193378837" X-IronPort-AV: E=Sophos;i="5.84,282,1620716400"; d="scan'208";a="193378837" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2021 06:50:53 -0700 X-IronPort-AV: E=Sophos;i="5.84,282,1620716400"; d="scan'208";a="508128490" Received: from crojewsk-mobl1.ger.corp.intel.com (HELO [10.213.24.117]) ([10.213.24.117]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2021 06:50:51 -0700 Subject: Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix drv_name To: Lukasz Majczak , Pierre-Louis Bossart Cc: upstream@semihalf.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20210730115906.144300-1-lma@semihalf.com> From: Cezary Rojewski Message-ID: Date: Fri, 30 Jul 2021 15:50:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210730115906.144300-1-lma@semihalf.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-30 1:59 PM, Lukasz Majczak wrote: > platform_id for kbl_da7219_max98357a was shrunk for kbl_da7219_mx98357a, > but the drv_name was changed for kbl_da7219_max98373. Tested on a > Pixelbook (Atlas). Reasoning behind Pierre's initial commit is valid and I believe kbl_da7219_max98373 name change was simply unintended. To make the situation clearer, please be more elaborate in commit's message. > Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters") > Cc: # 5.4+ > Reported-by: Cezary Rojewski Please reword to: Suggested-by. I certainly wasn't the one who found the problem first, but I did provide the initial fix. I don't see any problem is the code, so besides formalities: Reviewed-by: Cezary Rojewski Thanks, Czarek