LKML Archive on
help / color / mirror / Atom feed
From: Joe Perches <>
To: Len Baker <>, Jonathan Corbet <>,
	Kees Cook <>
Cc: "Gustavo A. R. Silva" <>,,,
Subject: Re: [PATCH] docs: deprecated.rst: Clarify open-coded arithmetic with literals
Date: Fri, 27 Aug 2021 12:06:18 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, 2021-08-27 at 19:12 +0200, Len Baker wrote:
> Although using literals for size calculation in allocator arguments may
> be harmless due to compiler warnings in case of overflows, it is better
> to refactor the code to avoid the use of open-coded math idiom.
> So, clarify the preferred way in these cases.
> diff --git a/Documentation/process/deprecated.rst b/Documentation/process/deprecated.rst
> @@ -60,7 +60,8 @@ smaller allocation being made than the caller was expecting. Using those
>  allocations could lead to linear overflows of heap memory and other
>  misbehaviors. (One exception to this is literal values where the compiler
>  can warn if they might overflow. Though using literals for arguments as
> -suggested below is also harmless.)
> +suggested below is also harmless. So, the preferred way in these cases is
> +to refactor the code to keep the open-coded math idiom out.)

wordsmithing trivia:

'keep <foo> out' is difficult to parse as 'keep' is generally a positive
word but its meaning is later reversed with out.

'avoid <foo>' maybe be better phrasing.

  reply	other threads:[~2021-08-27 19:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 17:12 Len Baker
2021-08-27 19:06 ` Joe Perches [this message]
2021-08-27 19:22   ` Gustavo A. R. Silva
2021-08-29 14:32   ` Len Baker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] docs: deprecated.rst: Clarify open-coded arithmetic with literals' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).