LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	moderated for non-subscribers <alsa-devel@alsa-project.org>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Jie Yang <yang.jie@linux.intel.com>
Subject: Re: [PATCH] ASoC: sound/soc/intel/boards: limit some drivers to X86 since headers are only in arch/x86/
Date: Thu, 23 May 2019 06:20:05 -0500	[thread overview]
Message-ID: <bdad5973-93e2-ea2b-85e9-c68635b6a5ba@linux.intel.com> (raw)
In-Reply-To: <46dc0767-bb21-2b98-90f2-34dd4bcad7c0@infradead.org>



On 5/22/19 10:58 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Several drivers in sound/soc/intel/boards/ #include header files
> that only exist in arch/x86/include/asm.  This causes build errors,
> so make these drivers depend on X86.
> 
> Fixes these build errors (on ia64):
> 
> ../sound/soc/intel/boards/bxt_da7219_max98357a.c:19:10: fatal error: asm/cpu_device_id.h: No such file or directory
>   #include <asm/cpu_device_id.h>
> ../sound/soc/intel/boards/bytcr_rt5640.c:31:10: fatal error: asm/cpu_device_id.h: No such file or directory
>   #include <asm/cpu_device_id.h>
> ../sound/soc/intel/boards/bytcr_rt5651.c:33:10: fatal error: asm/cpu_device_id.h: No such file or directory
>   #include <asm/cpu_device_id.h>
> ../sound/soc/intel/boards/cht_bsw_rt5645.c:29:10: fatal error: asm/cpu_device_id.h: No such file or directory
>   #include <asm/cpu_device_id.h>
> ../sound/soc/intel/boards/bytcht_es8316.c:33:10: fatal error: asm/cpu_device_id.h: No such file or directory
>   #include <asm/cpu_device_id.h>
> ../sound/soc/intel/boards/bytcht_da7213.c:26:10: fatal error: asm/platform_sst_audio.h: No such file or directory
>   #include <asm/platform_sst_audio.h>
> 
> And more drivers determined by:
>> grep "include.*asm.cpu_device_id.h" *.c
> bxt_da7219_max98357a.c:#include <asm/cpu_device_id.h>
> bytcht_es8316.c:#include <asm/cpu_device_id.h>
> bytcr_rt5640.c:#include <asm/cpu_device_id.h>
> bytcr_rt5651.c:#include <asm/cpu_device_id.h>
> cht_bsw_rt5645.c:#include <asm/cpu_device_id.h>
> sof_rt5682.c:#include <asm/cpu_device_id.h>
>    and
>> grep "include.*asm.platform_sst_audio.h" *.c
> bytcht_da7213.c:#include <asm/platform_sst_audio.h>
> bytcht_es8316.c:#include <asm/platform_sst_audio.h>
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>
> Cc: Jie Yang <yang.jie@linux.intel.com>
> Cc: alsa-devel@alsa-project.org
> ---
>   sound/soc/intel/boards/Kconfig |    6 ++++++
>   1 file changed, 6 insertions(+)
> 
> --- lnx-52-rc1.orig/sound/soc/intel/boards/Kconfig
> +++ lnx-52-rc1/sound/soc/intel/boards/Kconfig
> @@ -87,6 +87,7 @@ config SND_SOC_INTEL_BYTCR_RT5640_MACH
>   	tristate "Baytrail and Baytrail-CR with RT5640 codec"
>   	depends on I2C && ACPI
>   	depends on X86_INTEL_LPSS || COMPILE_TEST
> +	depends on X86

How does this improve the results?

config X86_INTEL_LPSS
	bool "Intel Low Power Subsystem Support"
	depends on X86 && ACPI && PCI

So the X86 dependency is already there. Does this happen with 
COMPILE_TEST set? If yes, maybe that's the part that needs to be 
changed? The addition of COMPILE_TEST here is quite recent and might 
need to be reverted.

  reply	other threads:[~2019-05-23 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  3:58 Randy Dunlap
2019-05-23 11:20 ` Pierre-Louis Bossart [this message]
2019-05-23 12:25   ` [alsa-devel] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bdad5973-93e2-ea2b-85e9-c68635b6a5ba@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=yang.jie@linux.intel.com \
    --subject='Re: [PATCH] ASoC: sound/soc/intel/boards: limit some drivers to X86 since headers are only in arch/x86/' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).