LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Manish Rangankar <mrangankar@marvell.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	Nilesh Javali <njavali@marvell.com>,
	GR-QLogic-Storage-Upstream
	<GR-QLogic-Storage-Upstream@marvell.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"open list:QLOGIC QL41xxx ISCSI DRIVER"
	<linux-scsi@vger.kernel.org>
Subject: Re: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable
Date: Fri, 26 Nov 2021 21:31:47 -0800	[thread overview]
Message-ID: <be1624fe-f1e5-f008-32e8-af00a36e284c@gmail.com> (raw)
In-Reply-To: <CO6PR18MB44199C2AE98B79EE9D46D679D8639@CO6PR18MB4419.namprd18.prod.outlook.com>



On 11/26/2021 12:52 AM, Manish Rangankar wrote:
> 
> 
>> -----Original Message-----
>> From: Florian Fainelli <f.fainelli@gmail.com>
>> Sent: Friday, November 26, 2021 10:45 AM
>> To: linux-kernel@vger.kernel.org
>> Cc: Florian Fainelli <f.fainelli@gmail.com>; kernel test robot <lkp@intel.com>;
>> Nilesh Javali <njavali@marvell.com>; Manish Rangankar
>> <mrangankar@marvell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
>> Storage-Upstream@marvell.com>; James E.J. Bottomley <jejb@linux.ibm.com>;
>> Martin K. Petersen <martin.petersen@oracle.com>; open list:QLOGIC QL41xxx
>> ISCSI DRIVER <linux-scsi@vger.kernel.org>
>> Subject: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> The variable page is set but never used throughout qedi_alloc_bdq() therefore
>> remove it.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>   drivers/scsi/qedi/qedi_main.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
>> 1dec814d8788..f1c933070884 100644
>> --- a/drivers/scsi/qedi/qedi_main.c
>> +++ b/drivers/scsi/qedi/qedi_main.c
>> @@ -1538,7 +1538,6 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
>>   	int i;
>>   	struct scsi_bd *pbl;
>>   	u64 *list;
>> -	dma_addr_t page;
>>
>>   	/* Alloc dma memory for BDQ buffers */
>>   	for (i = 0; i < QEDI_BDQ_NUM; i++) {
>> @@ -1608,11 +1607,9 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
>>   	qedi->bdq_pbl_list_num_entries = qedi->bdq_pbl_mem_size /
>>   					 QEDI_PAGE_SIZE;
>>   	list = (u64 *)qedi->bdq_pbl_list;
>> -	page = qedi->bdq_pbl_list_dma;
>>   	for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) {
>>   		*list = qedi->bdq_pbl_dma;
>>   		list++;
>> -		page += QEDI_PAGE_SIZE;
>>   	}
>>
>>   	return 0;
>> --
>> 2.25.1
> 
> Thanks,
> Acked-by: Manish Rangankar <mrangankar@marvell.com>

Thanks for taking a look, does not that make the loop iterating the list 
even more useless now, though? Should not page have been used for 
something in that function?
-- 
Florian

  reply	other threads:[~2021-11-27  5:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26  5:15 [PATCH 0/2] scsi: qedi: Couple of warning fixes Florian Fainelli
2021-11-26  5:15 ` [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable Florian Fainelli
2021-11-26  8:52   ` [EXT] " Manish Rangankar
2021-11-27  5:31     ` Florian Fainelli [this message]
2021-11-27  9:14       ` Manish Rangankar
2021-11-26  5:15 ` [PATCH 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT formatting Florian Fainelli
2021-11-26  8:43   ` [EXT] " Manish Rangankar
2021-11-27  5:31     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be1624fe-f1e5-f008-32e8-af00a36e284c@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=martin.petersen@oracle.com \
    --cc=mrangankar@marvell.com \
    --cc=njavali@marvell.com \
    --subject='Re: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused '\''page'\'' variable' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).