LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared
@ 2021-11-25  7:13 Naresh Kamboju
  2021-11-25  7:34 ` Kefeng Wang
  2021-11-25  7:53 ` Stephen Rothwell
  0 siblings, 2 replies; 5+ messages in thread
From: Naresh Kamboju @ 2021-11-25  7:13 UTC (permalink / raw)
  To: Linux-Next Mailing List, open list, linux-mm
  Cc: Stephen Rothwell, Andrew Morton, Kefeng Wang, Yongqiang Liu,
	Andrey Ryabinin, Dmitry Vyukov, Catalin Marinas, Will Deacon,
	Heiko Carstens, Vasily Gorbik, Christian Borntraeger,
	Alexander Gordeev, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
	Dave Hansen, Alexander Potapenko

[ Please ignore this email if it is already reported ]

While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
following warnings / errors noticed.

mm/kasan/shadow.c: In function 'kasan_module_alloc':
mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
  528 |                 if (vm->flags & VM_DELAY_KMEMLEAK)
      |                                 ^~~~~~~~~~~~~~~~~
      |                                 VM_DEFER_KMEMLEAK
mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
only once for each function it appears in
make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1

Build config:
https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config


Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

meta data:
-----------
    git describe: next-20211125
    git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
    git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
    git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
    target_arch: x86
    toolchain: gcc-11

steps to reproduce:
tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
--kconfig defconfig \
--kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config

https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh

--
Linaro LKFT
https://lkft.linaro.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared
  2021-11-25  7:13 [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared Naresh Kamboju
@ 2021-11-25  7:34 ` Kefeng Wang
  2021-11-26  5:06   ` Stephen Rothwell
  2021-11-25  7:53 ` Stephen Rothwell
  1 sibling, 1 reply; 5+ messages in thread
From: Kefeng Wang @ 2021-11-25  7:34 UTC (permalink / raw)
  To: Naresh Kamboju, Linux-Next Mailing List, open list, linux-mm
  Cc: Stephen Rothwell, Andrew Morton, Yongqiang Liu, Andrey Ryabinin,
	Dmitry Vyukov, Catalin Marinas, Will Deacon, Heiko Carstens,
	Vasily Gorbik, Christian Borntraeger, Alexander Gordeev,
	Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
	Alexander Potapenko

Sorry for the missing change of VM_DEFER_KMEMLEAK.

I will  add Fixes tag and resend v4.

On 2021/11/25 15:13, Naresh Kamboju wrote:
> [ Please ignore this email if it is already reported ]
>
> While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
> following warnings / errors noticed.
>
> mm/kasan/shadow.c: In function 'kasan_module_alloc':
> mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
> use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
>    528 |                 if (vm->flags & VM_DELAY_KMEMLEAK)
>        |                                 ^~~~~~~~~~~~~~~~~
>        |                                 VM_DEFER_KMEMLEAK
> mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
> only once for each function it appears in
> make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1
>
> Build config:
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> meta data:
> -----------
>      git describe: next-20211125
>      git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>      git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
>      git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
>      target_arch: x86
>      toolchain: gcc-11
>
> steps to reproduce:
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
> --kconfig defconfig \
> --kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh
>
> --
> Linaro LKFT
> https://lkft.linaro.org
> .

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared
  2021-11-25  7:13 [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared Naresh Kamboju
  2021-11-25  7:34 ` Kefeng Wang
@ 2021-11-25  7:53 ` Stephen Rothwell
  2021-11-25  8:04   ` Kefeng Wang
  1 sibling, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2021-11-25  7:53 UTC (permalink / raw)
  To: Naresh Kamboju
  Cc: Linux-Next Mailing List, open list, linux-mm, Andrew Morton,
	Kefeng Wang, Yongqiang Liu, Andrey Ryabinin, Dmitry Vyukov,
	Catalin Marinas, Will Deacon, Heiko Carstens, Vasily Gorbik,
	Christian Borntraeger, Alexander Gordeev, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, Dave Hansen, Alexander Potapenko

[-- Attachment #1: Type: text/plain, Size: 1868 bytes --]

Hi Naresh,

On Thu, 25 Nov 2021 12:43:41 +0530 Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>
> [ Please ignore this email if it is already reported ]
> 
> While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
> following warnings / errors noticed.
> 
> mm/kasan/shadow.c: In function 'kasan_module_alloc':
> mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
> use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
>   528 |                 if (vm->flags & VM_DELAY_KMEMLEAK)
>       |                                 ^~~~~~~~~~~~~~~~~
>       |                                 VM_DEFER_KMEMLEAK
> mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
> only once for each function it appears in
> make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1
> 
> Build config:
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
> 
> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> meta data:
> -----------
>     git describe: next-20211125
>     git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>     git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
>     git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
>     target_arch: x86
>     toolchain: gcc-11
> 
> steps to reproduce:
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
> --kconfig defconfig \
> --kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
> 
> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh
> 
> --
> Linaro LKFT
> https://lkft.linaro.org

Caused by commit

  f61bc9ffcab1 ("mm: defer kmemleak object creation of module_alloc()")

from the akpm-current tree.  The define is VM_DEFER_KMEMLEAK :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared
  2021-11-25  7:53 ` Stephen Rothwell
@ 2021-11-25  8:04   ` Kefeng Wang
  0 siblings, 0 replies; 5+ messages in thread
From: Kefeng Wang @ 2021-11-25  8:04 UTC (permalink / raw)
  To: Stephen Rothwell, Naresh Kamboju
  Cc: Linux-Next Mailing List, open list, linux-mm, Andrew Morton,
	Yongqiang Liu, Andrey Ryabinin, Dmitry Vyukov, Catalin Marinas,
	Will Deacon, Heiko Carstens, Vasily Gorbik,
	Christian Borntraeger, Alexander Gordeev, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, Dave Hansen, Alexander Potapenko


On 2021/11/25 15:53, Stephen Rothwell wrote:
> Hi Naresh,
>
> On Thu, 25 Nov 2021 12:43:41 +0530 Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>> [ Please ignore this email if it is already reported ]
>>
>> While building Linux next 20211125 x86 with CONFIG_KASAN=y gcc-11
>> following warnings / errors noticed.
>>
>> mm/kasan/shadow.c: In function 'kasan_module_alloc':
>> mm/kasan/shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared (first
>> use in this function); did you mean 'VM_DEFER_KMEMLEAK'?
>>    528 |                 if (vm->flags & VM_DELAY_KMEMLEAK)
>>        |                                 ^~~~~~~~~~~~~~~~~
>>        |                                 VM_DEFER_KMEMLEAK
>> mm/kasan/shadow.c:528:33: note: each undeclared identifier is reported
>> only once for each function it appears in
>> make[3]: *** [scripts/Makefile.build:288: mm/kasan/shadow.o] Error 1
>>
>> Build config:
>> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>>
>>
>> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>>
>> meta data:
>> -----------
>>      git describe: next-20211125
>>      git_repo: https://gitlab.com/Linaro/lkft/mirrors/next/linux-next
>>      git_sha: f81e94e91878bded599cc60f2881cfd50991aeb9
>>      git_short_log: f81e94e91878 (\"Add linux-next specific files for 20211125\")
>>      target_arch: x86
>>      toolchain: gcc-11
>>
>> steps to reproduce:
>> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-11
>> --kconfig defconfig \
>> --kconfig-add https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/config
>>
>> https://builds.tuxbuild.com/21OjEyx87iCX9bqOwJrZdl1wFFj/tuxmake_reproducer.sh
>>
>> --
>> Linaro LKFT
>> https://lkft.linaro.org
> Caused by commit
>
>    f61bc9ffcab1 ("mm: defer kmemleak object creation of module_alloc()")
>
> from the akpm-current tree.  The define is VM_DEFER_KMEMLEAK :-(
Resend a new one, sorry for missing macro change when v3 version use new 
name.
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared
  2021-11-25  7:34 ` Kefeng Wang
@ 2021-11-26  5:06   ` Stephen Rothwell
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Rothwell @ 2021-11-26  5:06 UTC (permalink / raw)
  To: Kefeng Wang
  Cc: Naresh Kamboju, Linux-Next Mailing List, open list, linux-mm,
	Andrew Morton, Yongqiang Liu, Andrey Ryabinin, Dmitry Vyukov,
	Catalin Marinas, Will Deacon, Heiko Carstens, Vasily Gorbik,
	Christian Borntraeger, Alexander Gordeev, Thomas Gleixner,
	Ingo Molnar, Borislav Petkov, Dave Hansen, Alexander Potapenko

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

Hi all,

On Thu, 25 Nov 2021 15:34:06 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:
>
> Sorry for the missing change of VM_DEFER_KMEMLEAK.
> 
> I will  add Fixes tag and resend v4.

I have applied the following patch to linux-next today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 26 Nov 2021 15:34:11 +1100
Subject: [PATCH] mm: kasan: fix VM_DELAY_KMEMLEAK typo

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 mm/kasan/shadow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c
index 2ade2f484562..94136f84b449 100644
--- a/mm/kasan/shadow.c
+++ b/mm/kasan/shadow.c
@@ -525,7 +525,7 @@ int kasan_module_alloc(void *addr, size_t size, gfp_t gfp_mask)
 		vm->flags |= VM_KASAN;
 		kmemleak_ignore(ret);
 
-		if (vm->flags & VM_DELAY_KMEMLEAK)
+		if (vm->flags & VM_DEFER_KMEMLEAK)
 			kmemleak_vmalloc(vm, size, gfp_mask);
 
 		return 0;
-- 
2.33.0

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-26  5:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25  7:13 [next] kasan: shadow.c:528:33: error: 'VM_DELAY_KMEMLEAK' undeclared Naresh Kamboju
2021-11-25  7:34 ` Kefeng Wang
2021-11-26  5:06   ` Stephen Rothwell
2021-11-25  7:53 ` Stephen Rothwell
2021-11-25  8:04   ` Kefeng Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).