LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: hid-related 5.2-rc1 boot hang
Date: Tue, 4 Jun 2019 10:36:27 +0200 [thread overview]
Message-ID: <c05929f4-00b6-e098-cd69-cd6539ccd3f1@redhat.com> (raw)
In-Reply-To: <4548d196-b75f-c4d0-8f3c-3e734b9a758c@redhat.com>
Hi,
On 04-06-19 10:05, Hans de Goede wrote:
<snip>
>>>> We should likely just remove c52f from the list of supported devices.
>>>> C52f receivers seem to have a different firmware as they are meant to
>>>> work with different devices than C534. So I guess it is safer to not
>>>> handle those right now and get the code in when it is ready.
>>>
>>> Ack. Can you prepare a patch to drop the c52f id?
>>
>> Yes. I have an other revert never submitted that I need to push, so I
>> guess I can do a revert session today.
>>
>> I think I'll also buy one device with hopefully the C52F receiver as
>> the report descriptors attached in
>> https://bugzilla.kernel.org/show_bug.cgi?id=203619 seems different to
>> what I would have expected.
>
> They are actually what I expected :)
>
> The first USB interface is a mouse boot class device, since this is a mouse
> only receiver. This means that the mouse report is unnumbered and we need to
> extend the unnumbered mouse-report handling to handle this case. Also the
> device is using the same highres mouse-reports as the gaming receiver is.
>
> I'm actually preparing a patch right now which should fix this. Still might
> be better to do the revert for 5.2 and get proper support for the c52f
> receiver into 5.3.
I've attached a patch to the bug:
https://bugzilla.kernel.org/show_bug.cgi?id=203619
Which should fix this. It is quite simple and safe, so if we get testing
feedback relatively soon, we could go with the fix instead of dropping the
product-id, your call.
Regards,
Hans
next prev parent reply other threads:[~2019-06-04 8:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 16:43 Dave Hansen
2019-05-28 17:14 ` Jiri Kosina
2019-05-28 17:45 ` Benjamin Tissoires
2019-05-28 18:11 ` Dave Hansen
2019-05-29 9:17 ` Hans de Goede
2019-05-30 16:56 ` Dave Hansen
2019-05-31 22:15 ` Jiri Kosina
2019-06-03 9:11 ` Hans de Goede
2019-06-03 9:32 ` Hans de Goede
2019-06-03 9:51 ` Hans de Goede
2019-06-03 13:55 ` Benjamin Tissoires
2019-06-03 14:17 ` Hans de Goede
2019-06-04 7:51 ` Benjamin Tissoires
2019-06-04 8:05 ` Hans de Goede
2019-06-04 8:36 ` Hans de Goede [this message]
2019-06-04 8:53 ` Benjamin Tissoires
2019-06-04 21:08 ` Jiri Kosina
2019-06-05 12:29 ` Benjamin Tissoires
2019-06-04 10:08 ` Benjamin Tissoires
2019-06-04 10:50 ` Hans de Goede
2019-06-04 12:25 ` Benjamin Tissoires
2019-06-04 13:12 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c05929f4-00b6-e098-cd69-cd6539ccd3f1@redhat.com \
--to=hdegoede@redhat.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dave.hansen@intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: hid-related 5.2-rc1 boot hang' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).