LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Skripkin <paskripkin@gmail.com>
To: Sean Young <sean@mess.org>
Cc: mkrufky@linuxtv.org, mchehab@kernel.org, crope@iki.fi,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com
Subject: Re: [PATCH] media: mxl111sf: change mutex_init() location
Date: Thu, 19 Aug 2021 12:31:35 +0300	[thread overview]
Message-ID: <c084ddbd-04ee-9033-5ec9-9d13cab05311@gmail.com> (raw)
In-Reply-To: <20210819092908.GA27679@gofer.mess.org>

On 8/19/21 12:29 PM, Sean Young wrote:
> On Sun, Aug 15, 2021 at 12:06:16PM +0300, Pavel Skripkin wrote:
>> On 8/15/21 11:49 AM, Pavel Skripkin wrote:
>> > On 8/15/21 11:37 AM, Sean Young wrote:
>> > > On Sat, Jul 31, 2021 at 12:38:29AM +0300, Pavel Skripkin wrote:
>> > > > Syzbot reported, that mxl111sf_ctrl_msg() uses uninitialized
>> > > > mutex. The problem was in wrong mutex_init() location.
>> > > > 
>> > > > Previous mutex_init(&state->msg_lock) call was in ->init() function, but
>> > > > dvb_usbv2_init() has this order of calls:
>> > > > 
>> > > > 	dvb_usbv2_init()
>> > > > 	  dvb_usbv2_adapter_init()
>> > > > 	    dvb_usbv2_adapter_frontend_init()
>> > > > 	      props->frontend_attach()
>> > > > 
>> > > > 	  props->init()
>> > > > 
>> > > > Since mxl111sf_frontend_attach_atsc_mh() calls mxl111sf_ctrl_msg()
>> > > > internally we need to initialize state->msg_lock in it to make lockdep
>> > > > happy.
>> > > 
>> > > What about the other frontends like mxl111sf_frontend_attach_dvbt? They
>> > > no longer initialize the mutex.
>> > > 
>> > Good point. I see, that all other frontends also call
>> > mxl111sf_ctrl_msg() inside ->frontend_attach() call.
>> > 
>> > I think, that fixing dvb-usb core is not good idea, so, I will add
>> > mutex_init() call inside all frontends, which use mxl111sf_init().
>> > 
>> > What do you think about it?
>> > 
>> > 
>> 
>> 
>> Something like this should work. Helper is just to not copy-paste code
>> parts. Build tested against v5.14-rc5
> 
> How about creating a dvb_usb_device_properties probe function and
> initializing the mutex init there?
> 
> 

Sounds reasonable. Will do it in v2, thank you!



With regards,
Pavel Skripkin

  reply	other threads:[~2021-08-19  9:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 21:38 Pavel Skripkin
2021-08-15  8:37 ` Sean Young
2021-08-15  8:49   ` Pavel Skripkin
2021-08-15  9:06     ` Pavel Skripkin
2021-08-19  9:29       ` Sean Young
2021-08-19  9:31         ` Pavel Skripkin [this message]
2021-08-19 10:38         ` [PATCH v2] " Pavel Skripkin
2021-08-19 10:42           ` [PATCH v3] " Pavel Skripkin
2021-09-12 15:49             ` Pavel Skripkin
2021-09-15 16:40               ` Sean Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c084ddbd-04ee-9033-5ec9-9d13cab05311@gmail.com \
    --to=paskripkin@gmail.com \
    --cc=crope@iki.fi \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=sean@mess.org \
    --cc=syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com \
    --subject='Re: [PATCH] media: mxl111sf: change mutex_init() location' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).